Hi,

https://github.com/apache/arrow/pull/5534 introduced 
ConcatenateTablesWithPromotion(). And there is already a ConcatenateTables() 
function which behaves differently (it requires the tables to have the schema). 
Wes raised a concern in that PR [1] that we might end up having many 
ConcatenateTables*() variants as there are various things that can be tweaked 
and he suggested to introduce a ConcatenateOptions so there is only one 
ConcatenateTables() function. 

While I'm onboard with that idea, I wanted to double check that there is a 
consensus that we should (as of today) merge ConcatenateTables() and 
ConcatenateTablesWithPromotion(), and have an option to do promotion or not (as 
in an earlier comment in the PR, @bkietz advised otherwise, but maybe at that 
point we didn't realize there were potentially many variants).

[1] https://github.com/apache/arrow/pull/5534#discussion_r343745573


Thanks,

Zhuo

Reply via email to