This notation is already used in some parts of the codebase [1]. I think it was introduced when absorbing gandiva and then in a draft of the logical operations in the compute module. I have no strong opinion for/against. I find it convenient to reduce typing, but the style guide argue against this.
What about other aliases (Vector & Iterator)? If we revert this change, we should do it uniformly, e.g. in gandiva and compute. François [1] https://gist.github.com/fsaintjacques/18720eebd9de3bb7770586ed8ec0ef6f On Thu, Nov 21, 2019 at 6:10 AM Antoine Pitrou <solip...@pitrou.net> wrote: > > On Wed, 20 Nov 2019 20:50:12 -0800 > Micah Kornfield <emkornfi...@gmail.com> wrote: > > A recent PR for datasets [1] seems to have introduced the convention of > > aliasing "std::shared_ptr<Type>" with "TypePtr" for some type. I think in > > the past we had decided not to use a convention like this but I can't find > > the thread. IMO, I think this generally makes the code less understandable > > but this is a matter of taste. > > I agree this introduces ambiguity for casual readers of the code. The > question is whether the savings in typing are worth it. Personally, > I've become used to writing "shared_ptr" a lot :-) > > Regards > > Antoine. > >
