Francois Saint-Jacques created ARROW-7338: ---------------------------------------------
Summary: [C++] Rename SimpleDataSource to InMemoryDataSource Key: ARROW-7338 URL: https://issues.apache.org/jira/browse/ARROW-7338 Project: Apache Arrow Issue Type: Improvement Components: C++ - Dataset Reporter: Francois Saint-Jacques The constructor should take a generator {code:c++} // Some comments here class InMemoryDataSource : public DataSource { public: using Generator = std::function<Iterator<std::shared_ptr<RecordBatch>>; InMemoryDataSource(Generator&& generator); // Convenience constructor to support a fixed list of RecordBatch InMemoryDataSource(std::shared_ptr<RecordBatch>); InMemoryDataSource(std::vector<std::shared_ptr<RecordBatch>>); private: Generator generator; } {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)