I admit that the status quo does not bother me that much, so `autopep8` as the more conservative / less aggressive option seems fine to me, and also makes it simple for people to fix up common linting issues in their PRs.
On Thu, Apr 2, 2020 at 5:16 AM Antoine Pitrou <solip...@pitrou.net> wrote: > > > I have looked at the kind of reformatting used by black and I've become > -1 on this. `black` is much too aggressive and actually makes the code > less readable. > > `autopep8` seems much better and less aggressive. Let's use that > instead. > > Regards > > Antoine. > > > On Thu, 26 Mar 2020 20:37:01 +0100 > Joris Van den Bossche <jorisvandenboss...@gmail.com> wrote: > > Hi all, > > > > I would like to propose adopting Black as code formatter within the python > > project. There is an older JIRA issue about this ( > > https://issues.apache.org/jira/browse/ARROW-5176), but bringing it to the > > mailing list for wider attention. > > > > Black (https://github.com/ambv/black) is a tool for automatically > > formatting python code in ways which flake8 and our other linters approve > > of (and fill a similar role to clang-format for C++ and cmake-format for > > cmake). It can also be added to the linting checks on CI and to the > > pre-commit hooks like we now run flake8. > > Using it ensures python code will be formatted consistently, and more > > importantly automates this formatting, letting you focus on more important > > matters. > > > > Black makes some specific formatting choices, and not everybody (me > > included) will always like those choices (that's how it goes with something > > subjective like formatting). But my experience with using it in some other > > big python projects (pandas, dask) has been very positive. You very quickly > > get used to how it looks, while it is much nicer to not have to worry about > > formatting anymore. > > > > Best, > > Joris > > > > >
