It looks like the rebase-PR step didn't work correctly per Micah's comment (didn't work on my PR for ARROW-2714 either). Might want to look into why not
On Tue, Apr 21, 2020 at 6:23 AM Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > > On Tue, Apr 21, 2020 at 4:28 AM Andy Grove <andygrov...@gmail.com> wrote: > > > > Well, I got trhe crates published, but there's a nasty workaround for users > > that want to use these crates as a dependency and it means there is no real > > dependency management on the Flight protocol version. I think the answer is > > that we need to publish the Flight.proto as part of the arrow-flight crate > > and make sure that version is used in the custom build script. I'll look at > > this again tomorrow and try and come up with a solution for the next > > release. > Thanks for handling it Andy! > > It occasionally happens that typically dependency problems come of with the > crates during the release. Can we automatize the testing of it? > > > > Here's the JIRA to track this specific issue. > > > > https://issues.apache.org/jira/browse/ARROW-8536 > I set it to critical for the next version. > > > > On Mon, Apr 20, 2020 at 7:49 PM Andy Grove <andygrov...@gmail.com> wrote: > > > > > I've run into issues publishing the Rust crates and I don't think I can > > > resolve this tonight. I am documenting the issue in > > > https://issues.apache.org/jira/browse/ARROW-8535 > > > > > > > > > On Mon, Apr 20, 2020 at 5:02 PM Krisztián Szűcs > > > <szucs.kriszt...@gmail.com> > > > wrote: > > > > > >> Created a PR with updated docs. > > >> > > >> Conda post release task is left, it's a bit strange that the conda-forge > > >> autotick bot has not created the version bump PRs yet. I'm updating > > >> them manually tomorrow. > > >> > > >> 1. [x] rebase > > >> 2. [x] upload source > > >> 3. [x] upload binaries > > >> 4. [x] update website > > >> 5. [x] upload ruby gems > > >> 6. [x] upload js packages > > >> 8. [x] upload C# packages > > >> 9. [Andy] upload rust crates > > >> 10. [ ] update conda recipes > > >> 11. [x] upload wheels to pypi > > >> 12. [Neal] update homebrew packages > > >> 13. [x] update maven artifacts > > >> 14. [kou] update msys2 > > >> 15. [Neal] update R packages > > >> 16. [x] update docs > > >> > > >> I'm going to announce 0.17 once the site PRs get merged. > > >> > > > >> > > > >> > Thanks, > > >> > -- > > >> > kou > > >> > > > >> > In <CAHM19a5FX96LLDaZk8zSozH=pw31at+TV1-yZJYHE=u+1f3...@mail.gmail.com> > > >> > "Re: [VOTE] Release Apache Arrow 0.17.0 - RC0" on Mon, 20 Apr 2020 > > >> 23:20:48 +0200, > > >> > Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > > >> > > > >> > > On Mon, Apr 20, 2020 at 11:17 PM Andy Grove <andygrov...@gmail.com> > > >> wrote: > > >> > >> > > >> > >> Ok, I can look into this after work today (in about 3 hours). > > >> > > Great, thanks! > > >> > > > > >> > > The current status is (`x` means done): > > >> > > > > >> > > 1. [x] rebase > > >> > > 2. [x] upload source > > >> > > 3. [x] upload binaries > > >> > > 4. [x] update website > > >> > > 5. [x] upload ruby gems > > >> > > 6. [x] upload js packages > > >> > > 8. [ ] upload C# crates > > >> > > 9. [Andy] upload rust crates > > >> > > 10. [ ] update conda recipes > > >> > > 11. [x] upload wheels to pypi > > >> > > 12. [Neal] update homebrew packages > > >> > > 13. [x] update maven artifacts > > >> > > 14. [ ] update msys2 > > >> > > 15. [Neal] update R packages > > >> > > 16. [Krisztian] update docs > > >> > >> > > >> > >> On Mon, Apr 20, 2020, 2:47 PM Krisztián Szűcs < > > >> szucs.kriszt...@gmail.com> > > >> > >> wrote: > > >> > >> > > >> > >> > Thanks Andy! I tried to upload the rust packages but arrow-flight, > > >> > >> > but a version pin is missing from the package tree: > > >> > >> > > > >> > >> > error: all dependencies must have a version specified when > > >> publishing. > > >> > >> > dependency `arrow-flight` does not specify a version > > >> > >> > > > >> > >> > Please upload the packages! > > >> > >> > > > >> > >> > Also added Uwe and Kou to the package owners. > > >> > >> > > > >> > >> > On Mon, Apr 20, 2020 at 10:24 PM Andy Grove > > >> > >> > <andygrov...@gmail.com> > > >> wrote: > > >> > >> > > > > >> > >> > > You should have an invite for the arrow-flight crate. Please > > >> check > > >> > >> > > https://crates.io/me/pending-invites > > >> > >> > > > > >> > >> > > On Mon, Apr 20, 2020 at 2:10 PM Krisztián Szűcs < > > >> > >> > szucs.kriszt...@gmail.com> > > >> > >> > > wrote: > > >> > >> > > > > >> > >> > > > 1. [x] rebase > > >> > >> > > > 2. [x] upload source > > >> > >> > > > 3. [x] upload binaries > > >> > >> > > > 4. [x] update website > > >> > >> > > > 5. [x] upload ruby gems > > >> > >> > > > 6. [x] upload js packages > > >> > >> > > > 8. [ ] upload C# crates > > >> > >> > > > 9. [ ] upload rust crates > > >> > >> > > > 10. [ ] update conda recipes > > >> > >> > > > 11. [-] upload wheels to pypi > > >> > >> > > > 12. [ ] update homebrew packages > > >> > >> > > > 13. [-] update maven artifacts > > >> > >> > > > 14. [ ] update msys2 > > >> > >> > > > 15. [ ] update R packages > > >> > >> > > > > > >> > >> > > > @Andy Grove please grant me access to the arrow-flight crate > > >> > >> > > > @Neal Richardson please update the R package > > >> > >> > > > > > >> > >> > > > Currently I'm handling maven and pypi artifacts. > > >> > >> > > > > > >> > >> > > > On Mon, Apr 20, 2020 at 8:27 PM Krisztián Szűcs > > >> > >> > > > <szucs.kriszt...@gmail.com> wrote: > > >> > >> > > > > > > >> > >> > > > > The VOTE carries with 7 binding +1 votes and 1 non-binding > > >> +1 vote. > > >> > >> > > > > > > >> > >> > > > > I'm starting the post-release tasks. I'm going to send > > >> updates to > > >> > >> > this > > >> > >> > > > > thread to coordinate if anyone wants to help. > > >> > >> > > > > > > >> > >> > > > > On Mon, Apr 20, 2020 at 3:25 PM Rok Mihevc < > > >> rok.mih...@gmail.com> > > >> > >> > wrote: > > >> > >> > > > > > > > >> > >> > > > > > +1 (non-binding) > > >> > >> > > > > > > > >> > >> > > > > > Tested on Ubuntu 18.04. C++ and Python builds / tests went > > >> fine. > > >> > >> > > > > > > > >> > >> > > > > > Rok > > >> > >> > > > > > > > >> > >> > > > > > On Mon, Apr 20, 2020 at 11:57 AM Krisztián Szűcs < > > >> > >> > > > szucs.kriszt...@gmail.com> > > >> > >> > > > > > wrote: > > >> > >> > > > > > > > >> > >> > > > > > > So far we're having 7 +1 binding votes. I'm planning to > > >> close the > > >> > >> > > > > > > vote later today, I anyone else would like to verify the > > >> release > > >> > >> > > > > > > please do it today. > > >> > >> > > > > > > > > >> > >> > > > > > > Thanks, Krisztian > > >> > >> > > > > > > > > >> > >> > > > > > > On Sun, Apr 19, 2020 at 10:59 PM Wes McKinney < > > >> > >> > wesmck...@gmail.com> > > >> > >> > > > wrote: > > >> > >> > > > > > > > > > >> > >> > > > > > > > +1 (binding) > > >> > >> > > > > > > > > > >> > >> > > > > > > > I was able to run the verification of source and > > >> wheels on > > >> > >> > Windows > > >> > >> > > > > > > > after addressing the issues I ran into. The failure > > >> reported in > > >> > >> > > > > > > > ARROW-8510 is worked around by using the UNITY build > > >> so we'll > > >> > >> > need > > >> > >> > > > to > > >> > >> > > > > > > > investigate that separately > > >> > >> > > > > > > > > > >> > >> > > > > > > > On Sat, Apr 18, 2020 at 4:01 PM Wes McKinney < > > >> > >> > wesmck...@gmail.com> > > >> > >> > > > > > > wrote: > > >> > >> > > > > > > > > > > >> > >> > > > > > > > > Right, sorry about that. > > >> > >> > > > > > > > > > > >> > >> > > > > > > > > So the difference it turns out is the UNITY build. > > >> The > > >> > >> > compiler > > >> > >> > > > error > > >> > >> > > > > > > > > in ARROW-8510 does not occur for some reason when > > >> > >> > > > > > > > > CMAKE_UNITY_BUILD=ON. > > >> > >> > > > > > > > > > > >> > >> > > > > > > > > On Sat, Apr 18, 2020 at 3:36 PM Antoine Pitrou < > > >> > >> > > > anto...@python.org> > > >> > >> > > > > > > wrote: > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > We build with both VS2015 and VS2017 on AppVeyor. > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > Regards > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > Antoine. > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > > > >> > >> > > > > > > > > > Le 18/04/2020 à 22:34, Wes McKinney a écrit : > > >> > >> > > > > > > > > > > The release verification script (which uses the > > >> VS 2017 > > >> > >> > > > compiler > > >> > >> > > > > > > mode) > > >> > >> > > > > > > > > > > fails for me on Windows > > >> > >> > > > > > > > > > > > > >> > >> > > > > > > > > > > https://issues.apache.org/jira/browse/ARROW-8510 > > >> > >> > > > > > > > > > > > > >> > >> > > > > > > > > > > It looks like we are building with VS 2019 in > > >> CI. We may > > >> > >> > > > want to be > > >> > >> > > > > > > > > > > more conservative and build with VS 2015 or VS > > >> 2017 in > > >> > >> > CI. > > >> > >> > > > This is > > >> > >> > > > > > > > > > > peculiar though because the wheels are using VS > > >> 2015. So > > >> > >> > it's > > >> > >> > > > > > > possible > > >> > >> > > > > > > > > > > there's a compiler bug with VS 2017 that doesn't > > >> present > > >> > >> > on > > >> > >> > > > VS > > >> > >> > > > > > > 2015. > > >> > >> > > > > > > > > > > > > >> > >> > > > > > > > > > > I don't think this should block the release > > >> however. I'll > > >> > >> > > > vote > > >> > >> > > > > > > after I > > >> > >> > > > > > > > > > > check some more things > > >> > >> > > > > > > > > > > > > >> > >> > > > > > > > > > > On Sat, Apr 18, 2020 at 3:32 PM Neal Richardson > > >> > >> > > > > > > > > > > <neal.p.richard...@gmail.com> wrote: > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >> +1 (binding) > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >> I ran verification on Ubuntu, macOS, and > > >> Windows using > > >> > >> > > > crossbow. > > >> > >> > > > > > > Thanks to > > >> > >> > > > > > > > > > >> all who helped debug. A few things are still > > >> failing: > > >> > >> > see > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > >> https://github.com/apache/arrow/pull/6961#issuecomment-615940240 > > >> > >> > > > > > > for > > >> > >> > > > > > > > > > >> details. Since Python folks are unconcerned by > > >> the wheel > > >> > >> > > > issues I > > >> > >> > > > > > > > > > >> encountered, I won't object. > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >> In addition to the usual verifications, I > > >> worked with > > >> > >> > > > Jeroen to > > >> > >> > > > > > > build the R > > >> > >> > > > > > > > > > >> Windows binaries for the 0.17 rc0 and confirmed > > >> that > > >> > >> > the R > > >> > >> > > > > > > package passes > > >> > >> > > > > > > > > > >> all checks with them. > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >> Neal > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >> On Sat, Apr 18, 2020 at 12:13 AM Sutou Kouhei < > > >> > >> > > > k...@clear-code.com> > > >> > >> > > > > > > wrote: > > >> > >> > > > > > > > > > >> > > >> > >> > > > > > > > > > >>> +1 (binding) > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> I ran the followings on Debian GNU/Linux sid: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> * TEST_CSHARP=0 \ > > >> > >> > > > > > > > > > >>> > > >> JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \ > > >> > >> > > > > > > > > > >>> CUDA_TOOLKIT_ROOT=/usr \ > > >> > >> > > > > > > > > > >>> > > >> ARROW_CMAKE_OPTIONS=-DgRPC_SOURCE=BUNDLED \ > > >> > >> > > > > > > > > > >>> > > >> dev/release/verify-release-candidate.sh source > > >> > >> > > > 0.17.0 0 > > >> > >> > > > > > > > > > >>> * dev/release/verify-release-candidate.sh > > >> binaries > > >> > >> > > > 0.17.0 0 > > >> > >> > > > > > > > > > >>> * dev/release/verify-release-candidate.sh > > >> wheels > > >> > >> > 0.17.0 0 > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> with: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> * gcc (Debian 9.3.0-10) 9.3.0 > > >> > >> > > > > > > > > > >>> * openjdk version "1.8.0_252" > > >> > >> > > > > > > > > > >>> * Node.JS v12.1.0 > > >> > >> > > > > > > > > > >>> * nvidia-cuda-dev 10.1.168-8 > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> Notes: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> * C# sourcelink is failed as usual. > > >> > >> > > > > > > > > > >>> > > >> https://issues.apache.org/jira/browse/ARROW-8505 > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> Thanks, > > >> > >> > > > > > > > > > >>> -- > > >> > >> > > > > > > > > > >>> kou > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>> In <CAHM19a5t9=xuMHPgp=qDj3F2Bp-30wq= > > >> > >> > > > > > > ykocv1cymwkvhuk...@mail.gmail.com> > > >> > >> > > > > > > > > > >>> "[VOTE] Release Apache Arrow 0.17.0 - RC0" > > >> on Fri, 17 > > >> > >> > > > Apr 2020 > > >> > >> > > > > > > 02:26:34 > > >> > >> > > > > > > > > > >>> +0200, > > >> > >> > > > > > > > > > >>> Krisztián Szűcs <szucs.kriszt...@gmail.com> > > >> wrote: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > > >>>> Hi, > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> I would like to propose the following release > > >> > >> > candidate > > >> > >> > > > (RC0) > > >> > >> > > > > > > of Apache > > >> > >> > > > > > > > > > >>>> Arrow version 0.17.0. This is a release > > >> consisting of > > >> > >> > 582 > > >> > >> > > > > > > > > > >>>> resolved JIRA issues[1]. > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> This release candidate is based on commit: > > >> > >> > > > > > > > > > >>>> 3cbcb7b62c2f2d02851bff837758637eb592a64b [2] > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> The source release rc0 is hosted at [3]. > > >> > >> > > > > > > > > > >>>> The binary artifacts are hosted at > > >> [4][5][6][7]. > > >> > >> > > > > > > > > > >>>> The changelog is located at [8]. > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> Please download, verify checksums and > > >> signatures, run > > >> > >> > the > > >> > >> > > > unit > > >> > >> > > > > > > tests, > > >> > >> > > > > > > > > > >>>> and vote on the release. See [9] for how to > > >> validate a > > >> > >> > > > release > > >> > >> > > > > > > candidate. > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> The vote will be open for at least 72 hours. > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> [ ] +1 Release this as Apache Arrow 0.17.0 > > >> > >> > > > > > > > > > >>>> [ ] +0 > > >> > >> > > > > > > > > > >>>> [ ] -1 Do not release this as Apache Arrow > > >> 0.17.0 > > >> > >> > > > because... > > >> > >> > > > > > > > > > >>>> > > >> > >> > > > > > > > > > >>>> [1]: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.17.0 > > >> > >> > > > > > > > > > >>>> [2]: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> https://github.com/apache/arrow/tree/3cbcb7b62c2f2d02851bff837758637eb592a64b > > >> > >> > > > > > > > > > >>>> [3]: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.17.0-rc0 > > >> > >> > > > > > > > > > >>>> [4]: > > >> > >> > > > https://bintray.com/apache/arrow/centos-rc/0.17.0-rc0 > > >> > >> > > > > > > > > > >>>> [5]: > > >> > >> > > > https://bintray.com/apache/arrow/debian-rc/0.17.0-rc0 > > >> > >> > > > > > > > > > >>>> [6]: > > >> > >> > > > https://bintray.com/apache/arrow/python-rc/0.17.0-rc0 > > >> > >> > > > > > > > > > >>>> [7]: > > >> > >> > > > https://bintray.com/apache/arrow/ubuntu-rc/0.17.0-rc0 > > >> > >> > > > > > > > > > >>>> [8]: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> https://github.com/apache/arrow/blob/3cbcb7b62c2f2d02851bff837758637eb592a64b/CHANGELOG.md > > >> > >> > > > > > > > > > >>>> [9]: > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > >> > >> > > > > > > > > > >>> > > >> > >> > > > > > > > > >> > >> > > > > > >> > >> > > > >> > > >
