I commented that out because the same logic is in the release verification guide, so it sounded like something that should be handled outside of the script (and yes, it caused the script to fail on GHA).
https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates Neal On Thu, May 14, 2020 at 11:21 AM Wes McKinney <wesmck...@gmail.com> wrote: > I had gone to the effort of making the JS tests pass on machines that > have a too-old Node but it got commented out because of issues running > inside GHA, perhaps this code path can be made available by > environment variable (opt-out so it can be disabled in GHA but used > elsewhere)? > > > https://github.com/apache/arrow/blob/master/dev/release/verify-release-candidate.sh#L423 > > On Thu, May 14, 2020 at 12:30 PM Antoine Pitrou <anto...@python.org> > wrote: > > > > > > +1 from me. > > > > I tested the sources on Ubuntu 18.04, with CUDA enabled. It worked > > until the Javascript step, which failed (as usual). > > > > I'm testing the binaries but it seems to download gigabytes of data as > > usual, so I'll probably stop it before it finishes. > > > > Regards > > > > Antoine. > > > > > > Le 14/05/2020 à 18:23, Krisztián Szűcs a écrit : > > > Hi, > > > > > > I would like to propose the following release candidate (RC1) of Apache > > > Arrow version 0.17.1. This is a release consisting of 19 > > > resolved JIRA issues[1]. > > > > > > This release candidate is based on commit: > > > ff7ee06020949daf66ac05090753e1a17736d9fa [2] > > > > > > The source release rc1 is hosted at [3]. > > > The binary artifacts are hosted at [4][5][6][7]. > > > The changelog is located at [8]. > > > > > > Please download, verify checksums and signatures, run the unit tests, > > > and vote on the release. See [9] for how to validate a release > candidate. > > > > > > The vote will be open for at least 72 hours. > > > > > > [ ] +1 Release this as Apache Arrow 0.17.1 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Arrow 0.17.1 because... > > > > > > [1]: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.17.1 > > > [2]: > https://github.com/apache/arrow/tree/ff7ee06020949daf66ac05090753e1a17736d9fa > > > [3]: > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.17.1-rc1 > > > [4]: https://bintray.com/apache/arrow/centos-rc/0.17.1-rc1 > > > [5]: https://bintray.com/apache/arrow/debian-rc/0.17.1-rc1 > > > [6]: https://bintray.com/apache/arrow/python-rc/0.17.1-rc1 > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/0.17.1-rc1 > > > [8]: > https://github.com/apache/arrow/blob/ff7ee06020949daf66ac05090753e1a17736d9fa/CHANGELOG.md > > > [9]: > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > >
