Hi Antoine, Sounds good to me. This PR is already being actively reviewed, and it'd be good to have Itamar's assessment.
Cheers, Gidon On Thu, Sep 3, 2020 at 6:01 PM Antoine Pitrou <anto...@python.org> wrote: > > Hi Gidon, > > Le 03/09/2020 à 16:53, Gidon Gershinsky a écrit : > > Hi Itamar, > > > > My suggestion would be wrap a different API in Python - the high-level > > encryption interface of > > https://github.com/apache/arrow/pull/8023 > > We need a strategy for reviewing those changes. The PR is quite large, > touches a functionality that few people are competent with (I'm not even > sure how deeply the current encryption functionality was reviewed before > merging, I think it just mostly looked right and the tests passed), and > the Parquet development community is generally not very vibrant. > > Perhaps Itamar could help give an assessment on those changes if he > feels confident. Also someone will minimally have to make a pass and > point any coding style / API convention issues, etc. > > Regards > > Antoine. >
