+1 Great work everyone!
On Fri, Aug 13, 2021, 22:19 Daniël Heres <danielhe...@gmail.com> wrote: > +1 (non binding). Looking good. > > > On Fri, Aug 13, 2021, 07:49 QP Hou <houqp....@gmail.com> wrote: > > > Good call Ruihang. I remember we used to have this toolchain file when > > we were still in the main arrow repo. I will take a look into that. > > > > On Wed, Aug 11, 2021 at 5:36 PM Wayne Xia <waynest...@gmail.com> wrote: > > > > > > Hi QP, > > > > > > When running this script I noticed that this might be because I was not > > > using a stable toolchain when testing. > > > Those failures occur with nightly (which is my default toolchain). And > > > everything works fine after switching to stable 1.54. > > > So I think it's ok from my side to vote +1. > > > > > > BTW, I think we can add a toolchain file [1] to datafusion repo. > > > > > > [1]: > > https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file > > > > > > On Thu, Aug 12, 2021 at 2:14 AM QP Hou <houqp....@gmail.com> wrote: > > > > > > > Hi Ruihang, > > > > > > > > Thanks for helping with the validation. It would certainly be helpful > > > > if you could share the error log with me. > > > > > > > > I have also prepared an updated version of the verification script at > > > > > > > > > > > https://github.com/houqp/arrow-datafusion/blob/qp_release/dev/release/verify-release-candidate.sh > > > > . > > > > This script does a clean checkout of everything before running tests > > > > and linting tools. Could you give that a try to see if you are > getting > > > > the same results? > > > > > > > > Thanks, > > > > QP > > > > > > > > On Wed, Aug 11, 2021 at 6:38 AM Wayne Xia <waynest...@gmail.com> > > wrote: > > > > > > > > > > Thanks, QP! > > > > > > > > > > I verified the signature and checked shasum, but got 3 failed case > > while > > > > > testing: > > > > > > > > > > - execution_plans::shuffle_writer::tests::test > > > > > - execution_plans::shuffle_writer::tests::test_partitioned > > > > > - > > > > > > > physical_plan::repartition::tests::repartition_with_dropping_output_stream > > > > > > > > > > I set up env `ARROW_TEST_DATA` and `PARQUET_TEST_DATA`, then run > the > > test > > > > > with > > > > > "cargo test --all --no-fail-fast" on Linux 5.13.6 with x86_64 chip. > > > > > > > > > > Did I miss something? I can paste the log here or file an issue if > > > > needed. > > > > > > > > > > Ruihang > > > > > > > > > > QP Hou <houqp....@gmail.com>： > > > > > > > > > > > Hi, > > > > > > > > > > > > I would like to propose a release of Apache Arrow Datafusion > > > > > > Implementation, > > > > > > version 5.0.0. > > > > > > > > > > > > RC3 fixed a cargo publish issue discovered in RC1. > > > > > > > > > > > > This release candidate is based on commit: > > > > > > deb929369c9aaba728ae0c2c49dcd05bfecc8bf8 [1] > > > > > > The proposed release tarball and signatures are hosted at [2]. > > > > > > The changelog is located at [3]. > > > > > > > > > > > > Please download, verify checksums and signatures, run the unit > > tests, > > > > and > > > > > > vote > > > > > > on the release. The vote will be open for at least 72 hours. > > > > > > > > > > > > [ ] +1 Release this as Apache Arrow Datafusion 5.0.0 > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this as Apache Arrow Datafusion 5.0.0 > > because... > > > > > > > > > > > > [1]: > > > > > > > > > > > > > https://github.com/apache/arrow-datafusion/tree/deb929369c9aaba728ae0c2c49dcd05bfecc8bf8 > > > > > > [2]: > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc3 > > > > > > [3]: > > > > > > > > > > > > > https://github.com/apache/arrow-datafusion/blob/deb929369c9aaba728ae0c2c49dcd05bfecc8bf8/CHANGELOG.md > > > > > > > > > > > > Thanks, > > > > > > QP > > > > > > > > > > > > >
