Re: [VOTE] Release Apache Arrow 7.0.0 - RC10

Sun, 30 Jan 2022 04:09:42 -0800 

+1 Non binding

Checks on Rocky Linux 8, x86-64, GNU 8.5

Source  C++, Python, GLib, Ruby, Java, Go, Javascript
Wheels
Binaries

Some of the warnings below:
/tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/compute/exec/ir_consumer.cc: In function ‘arrow::Result<arrow::compute::Declaration> arrow::compute::Convert(const org::apache::arrow::computeir::flatbuf::Relation&)’: /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/compute/exec/ir_consumer.cc:649:30: warning: ‘key_null_placement’ may be used uninitialized in this function [-Wmaybe-uninitialized] SortOptions{std::move(sort_keys), *null_placement}, nullptr},
/tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/plasma/test/serialization_tests.cc: In member function ‘int plasma::TestPlasmaSerialization::CreateTemporaryFile()’: /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/plasma/test/serialization_tests.cc:85:12: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 1024 equals destination size [-Wstringop-truncation] 
     strncpy(path, ss.str().c_str(), sizeof(path));
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function ‘int plasma::TestPlasmaSerialization::CreateTemporaryFile()’, inlined from ‘virtual void plasma::TestPlasmaSerialization_EvictRequest_Test::TestBody()’ at /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/plasma/test/serialization_tests.cc:275:31: /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/plasma/test/serialization_tests.cc:85:12: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 1024 equals destination size [-Wstringop-truncation] 
     strncpy(path, ss.str().c_str(), sizeof(path));
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/util/bit_run_reader.h:26, from /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/util/bit_util_test.cc:45: /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/util/bitmap_reader.h: In function ‘void arrow::TestBitmapUInt64Reader::AssertWords(const arrow::Buffer&, int64_t, int64_t, const std::vector<long unsigned int>&)’: /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/util/bitmap_reader.h:99:16: warning: ‘reader.arrow::internal::BitmapUInt64Reader::carry_bits_’ may be used uninitialized in this function [-Wmaybe-uninitialized] 
       uint64_t word = carry_bits_ | (next_word << num_carry_bits_);
                ^~~~
/tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/cpp/src/arrow/util/bit_util_test.cc:245:34: note: ‘reader.arrow::internal::BitmapUInt64Reader::carry_bits_’ was declared here internal::BitmapUInt64Reader reader(buffer.data(), start_offset, length); 


+ bundle --version
Bundler version 2.2.24
+ bundle install --path vendor/bundle
[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path 'vendor/bundle'`, and stop using this flag Don't run Bundler as root. Bundler can ask for sudo if it is needed, and installing your bundle as root will break this application 
for all non-root users on this machine.
In file included from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39, from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2458, 
                 from /usr/include/c++/8/cstdint:38,
from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array/array_base.h:20, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array.h:37, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/api.h:22, 
                 from red-arrow.hpp:22,
                 from arrow.cpp:20:
/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp] 
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^~~~~~~
In file included from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39, from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2458, 
                 from /usr/include/c++/8/cstdint:38,
from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array/array_base.h:20, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array.h:37, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/api.h:22, 
                 from red-arrow.hpp:22,
                 from converters.hpp:20,
                 from converters.cpp:20:
/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp] 
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^~~~~~~
In file included from /usr/include/bits/libc-header-start.h:33,
                 from /usr/include/stdio.h:27,
                 from /usr/include/ruby/defines.h:126,
                 from /usr/include/ruby/ruby.h:29,
                 from /usr/include/ruby.h:33,
from /tmp/arrow-7.0.0.v8rVF/apache-arrow-7.0.0/ruby/red-arrow/vendor/bundle/ruby/2.7.0/gems/extpp-0.1.0/include/ruby.hpp:3, 
                 from memory-view.hpp:20,
                 from memory-view.cpp:20:
/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp] 
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^~~~~~~
In file included from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39, from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2458, 
                 from /usr/include/c++/8/cstdint:38,
from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array/array_base.h:20, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array.h:37, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/api.h:22, 
                 from red-arrow.hpp:22,
                 from converters.hpp:20,
                 from raw-records.cpp:20:
/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp] 
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^~~~~~~
In file included from /usr/include/c++/8/x86_64-redhat-linux/bits/os_defines.h:39, from /usr/include/c++/8/x86_64-redhat-linux/bits/c++config.h:2458, 
                 from /usr/include/c++/8/cstdint:38,
from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array/array_base.h:20, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/array.h:37, from /tmp/arrow-7.0.0.v8rVF/install/include/arrow/api.h:22, 
                 from red-arrow.hpp:22,
                 from converters.hpp:20,
                 from values.cpp:20:
/usr/include/features.h:381:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp] 
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^~~~~~~





On 1/29/22 10:23 PM, Antoine Pitrou wrote:


+1

The following checks were succesful on Ubuntu 20.04, x86-64:

- source release test with gcc 9.3.0, C++, Python, GLib, Ruby, CUDA
- source release test with gcc 8.4.0, C++, Python, GLib, Ruby, CUDA
- source release test with clang 10.0.0, C++, Python, GLib, Ruby, CUDA
- source release test with Java, Go, Javascript

The following test failed on Debian oldstable, x86-64:

- wheel release test (*)

Regards

Antoine.


(*) Here is the end of the logs:

+ pushd binaries
/tmp/arrow-7.0.0.C5b7S/binaries /tmp/arrow-7.0.0.C5b7S
++ uname
+ '[' Linux == Darwin ']'
+ test_linux_wheels
++ uname -m
+ '[' x86_64 = aarch64 ']'
+ local arch=x86_64
+ local 'py_arches=3.7m 3.8 3.9 3.10'
+ local 'platform_tags=manylinux_2_12_x86_64.manylinux2010_x86_64 manylinux_2_17_x86_64.manylinux2014_x86_64' 
+ for py_arch in ${py_arches}
+ local env=_verify_wheel-3.7m
+ '[' 3.7m = 3.10 ']'
+ local 'channels=-c conda-forge'
+ mamba create -yq -n _verify_wheel-3.7m -c conda-forge python=3.7
./dev/release/verify-release-candidate.sh: line 646: mamba: command not found 
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /tmp/arrow-7.0.0.C5b7S for details.' 
Failed to verify release candidate. See /tmp/arrow-7.0.0.C5b7S for details.




Le 29/01/2022 à 12:28, Krisztián Szűcs a écrit :

Hi,

I would like to propose the following release candidate (RC10) of Apache
Arrow version 7.0.0. This is a release consisting of 649
resolved JIRA issues[1].

This release candidate is based on commit:
e90472e35b40f58b17d408438bb8de1641bfe6ef [2]

The source release rc10 is hosted at [3].
The binary artifacts are hosted at [4][5][6][7][8][9][10][11].
The changelog is located at [12].

Please download, verify checksums and signatures, run the unit tests,
and vote on the release. See [13] for how to validate a release candidate. 

The crossbow release verification tasks' results are available at [14].

The vote will be open for at least 72 hours.

[ ] +1 Release this as Apache Arrow 7.0.0
[ ] +0
[ ] -1 Do not release this as Apache Arrow 7.0.0 because...
[1]: https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%207.0.0 [2]: https://github.com/apache/arrow/tree/e90472e35b40f58b17d408438bb8de1641bfe6ef 
[3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-7.0.0-rc10
[4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
[5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
[6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
[7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
[8]: https://apache.jfrog.io/artifactory/arrow/java-rc/7.0.0-rc10
[9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/7.0.0-rc10
[10]: https://apache.jfrog.io/artifactory/arrow/python-rc/7.0.0-rc10
[11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
[12]: https://github.com/apache/arrow/blob/e90472e35b40f58b17d408438bb8de1641bfe6ef/CHANGELOG.md [13]: https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates 
[14]: https://github.com/apache/arrow/pull/12293

Reply via email to