My vote: +1 (binding) The vote passes with 4 binding +1 votes and 3 non-binding +1 votes. Thanks to all who contributed.
I'll circle back on the PR comments before merging. On Mon, Apr 25, 2022, at 15:43, Wes McKinney wrote: > +1 (binding) > > I agree with the comments on the PR that it would be good to better > explain what the "type name" is or give an example or reference in the > code comments > > On Thu, Apr 21, 2022 at 11:49 AM José Almeida > <[email protected]> wrote: >> >> +1 (non binding) >> >> On Thu, Apr 21, 2022 at 1:49 PM Rafael Telles <[email protected]> wrote: >> >> > +1 non-binding >> > >> > Em qui., 21 de abr. de 2022 às 13:42, Micah Kornfield < >> > [email protected]> >> > escreveu: >> > >> > > +1 from me. >> > > >> > > On Thu, Apr 21, 2022 at 5:40 AM Antoine Pitrou <[email protected]> >> > wrote: >> > > >> > > > >> > > > +1 from me (binding), with caveat that I'm not competent in JDBC and >> > the >> > > > proposed changes in PR [3] look reasonable to me. >> > > > >> > > > Best regards >> > > > >> > > > Antoine. >> > > > >> > > > >> > > > Le 20/04/2022 à 22:13, David Li a écrit : >> > > > > Hello, >> > > > > >> > > > > Iury da Guia Salino has proposed an addition to Arrow Flight SQL, an >> > > > experimental protocol for interacting with SQL databases over Arrow >> > > Flight. >> > > > This adds on to the previous proposal [1] adding an additional "type >> > > name" >> > > > metadata field on returned schemas for use by the JDBC driver being >> > > > implemented by their team [2]. >> > > > > >> > > > > The pull request [3] implements the additions in C++ and Java and >> > > > contains integration tests. >> > > > > >> > > > > Please vote whether to accept these enhancements. The vote will be >> > open >> > > > for at least 72 hours. >> > > > > >> > > > > [ ] +1 Accept these protocol additions >> > > > > [ ] +0 >> > > > > [ ] -1 Do not accept these protocol additions because… >> > > > > >> > > > > [1]: "[VOTE] Extend Arrow Flight SQL with GetXdbcTypeInfo, SQL type >> > > info >> > > > in schemas" >> > > > https://lists.apache.org/thread/ynlyjcc5k66dbjphv485nl2nt6ztbbzt >> > > > > [2]: https://github.com/apache/arrow/pull/12254 >> > > > > [3]: https://github.com/apache/arrow/pull/12747 >> > > > > >> > > > > Thanks, >> > > > > David >> > > > >> > > >> >
