+1 (verified on mac x86) I took a look through the PRs -- I think [1] is actually SemVer but I wanted to double check (to see if we needed to make the version 0.6.0 🤔)
The ::new() constructor is the same, but ApplicationDefaultCredentialsFile went from a struct to enum [1] https://github.com/apache/arrow-rs/pull/3799/files On Fri, Mar 31, 2023 at 1:47 PM L. C. Hsieh <vii...@gmail.com> wrote: > Oh, I verified RC1 wrongly. Then for RC2, > > +1 (binding) > > Verified on M1 Mac. > > Thanks Raphael. > > > > On Fri, Mar 31, 2023 at 10:34 AM Raphael Taylor-Davies > <r.taylordav...@googlemail.com.invalid> wrote: > > > > Are you verifying RC1 or RC2? RC1 had the issue you mention > > > > On 31/03/2023 18:17, L. C. Hsieh wrote: > > > Hmm, I got an error like following on both M1 and Intel Macs. > > > > > > ``` > > > + cargo build > > > > > > error: failed to parse manifest at > > > > `/private/var/folders/zq/2tdnn5955wvdcw7qfy6qhvk00000gn/T/arrow-0.5.6.XXXXX.VnNkJPdg/apache-arrow-object-store-rs-0.5.6/Cargo.toml` > > > > > > > > > Caused by: > > > > > > error inheriting `edition` from workspace root manifest's > > > `workspace.package.edition` > > > > > > > > > Caused by: > > > > > > failed to find a workspace root > > > ``` > > > > > > On Fri, Mar 31, 2023 at 8:06 AM Will Jones <will.jones...@gmail.com> > wrote: > > >> +1 > > >> Verified on M1 MacOS. > > >> > > >> > > >> On Fri, Mar 31, 2023 at 4:29 AM Raphael Taylor-Davies > > >> <r.taylordav...@googlemail.com.invalid> wrote: > > >> > > >>> Hi, > > >>> > > >>> I would like to propose a release of Apache Arrow Rust Object > > >>> Store Implementation, version 0.5.6. > > >>> > > >>> This release candidate is based on commit: > > >>> 234b7847ecb737e96df3f4623df7b330b34b3d1b [1] > > >>> > > >>> The proposed release tarball and signatures are hosted at [2]. > > >>> > > >>> The changelog is located at [3]. > > >>> > > >>> Please download, verify checksums and signatures, run the unit tests, > > >>> and vote on the release. There is a script [4] that automates some of > > >>> the verification. > > >>> > > >>> The vote will be open for at least 72 hours. > > >>> > > >>> [ ] +1 Release this as Apache Arrow Rust Object Store > > >>> [ ] +0 > > >>> [ ] -1 Do not release this as Apache Arrow Rust Object Store > because... > > >>> > > >>> [1]: > > >>> > > >>> > https://github.com/apache/arrow-rs/tree/234b7847ecb737e96df3f4623df7b330b34b3d1b > > >>> [2]: > > >>> > > >>> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-object-store-rs-0.5.6-rc2 > > >>> [3]: > > >>> > > >>> > https://github.com/apache/arrow-rs/blob/234b7847ecb737e96df3f4623df7b330b34b3d1b/object_store/CHANGELOG.md > > >>> [4]: > > >>> > > >>> > https://github.com/apache/arrow-rs/blob/master/object_store/dev/release/verify-release-candidate.sh > > >>> > > >>> >
