Hi,

Ah, sorry. I should have written it in the original e-mail.

If we can require CMake 3.16+:

* We can always use the precompiled headers feature that
  reduces build time:
  
https://github.com/apache/arrow/pull/35921/files#diff-1bba462ab050e89360fd88110a689e85ee037749cea091a1848ab574381d3795L236

* We can remove our bundled FindPythonLibsNew.cmake and
  FindNumPy.cmake:
  
https://github.com/apache/arrow/pull/35921/files#diff-96c2eed475b13f84b0e0b4ce871fcf225d3d75d8c1ebd9d2b2d7183fa2a603f5L44

  Users don't need to specify both of -DPYTHON_EXECUTABLE
  and -DPython3_EXECUTABLE for old/new CMake:
  
https://github.com/apache/arrow/pull/35921/files#diff-91a09bc7b04c0122375fb44ec755065daccba993f95f96a26df129c4df9bb438L377

* We can remove a Boost::headers related shim code:
  
https://github.com/apache/arrow/pull/35921/files#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aL1203

* Jacob wants to use FetchContent related features:
  https://github.com/apache/arrow/pull/35921#issuecomment-1585428356


Thanks,
-- 
kou

In <ce9e91cb-52e6-32e5-9ca3-baf904799...@python.org>
  "Re: [DISCUSS][C++] Can we require CMake 3.16+ since 13.0.0?" on Thu, 15 Jun 
2023 23:36:10 +0200,
  Antoine Pitrou <anto...@python.org> wrote:

> 
> Hi,
> 
> I'd ask the question differently: what do we gain from requiring 3.16
> rather than 3.13?
> 
> 
> Le 15/06/2023 à 23:19, Sutou Kouhei a écrit :
>> Hi,
>> We require CMake 3.5+ now because Ubuntu 18.04 ships 3.5.
>> We dropped support for Ubuntu 18.04 because it reached EOL.
>> Can we require CMake 3.16+ in Apache Arrow C++ 13.0.0?
>> Here are CMake versions of our supported platforms:
>> * Ubuntu 20.04: CMake 3.16
>> * CentOS 7: CMake 3.17
>> * Debian GNU/Linux bullseye: 3.18
>> * Amazon Linux 2: CMake 3.13!!!
>> See the Amazon Linux 2 item. It ships CMake 3.13 not CMake
>> 3.16+. Can we drop support for Amazon Linux 2 in Apache
>> Arrow C++ 13.0.0?
>> FYI1: Amazon Linux released a new version (Amazon Linux
>> 2023) on 2023-03-15:
>> Amazon Linux 2023, a Cloud-Optimized Linux Distribution with
>> Long-Term Support
>> https://aws.amazon.com/blogs/aws/amazon-linux-2023-a-cloud-optimized-linux-distribution-with-long-term-support/
>> FYI2: Amazon Linux 2 was scheduled to reach EOL on
>> 2023-06-30 but has been extended to 2025-06-30:
>> https://aws.amazon.com/amazon-linux-2/faqs/
>> 
>>> Amazon Linux 2 end of support date (End of Life, or EOL)
>>> has been extended by two years from 2023-06-30 to
>>> 2025-06-30 to provide customers with ample time to migrate
>>> to the next version.
>> FYI3: We'll support Amazon Linux 2023 in Apache Arrow C++
>> 13.0.0:
>> https://github.com/apache/arrow/pull/36081
>> Related issue:
>> [C++] Require CMake 3.16 or later
>> https://github.com/apache/arrow/issues/34921
>> Thanks,

Reply via email to