+1 (binding)
Tested on M1 Mac
On first try I got this failing test (increased open file limit to pass)
failures:
---- fuzz_cases::order_spill_fuzz::test_sort_1k_mem stdout ----
thread 'fuzz_cases::order_spill_fuzz::test_sort_1k_mem' panicked at 'called
`Result::unwrap()` on an `Err` value: Execution("Failed to create partition
file at
\"/var/folders/3b/xk_bhzc565q0mz5j4yw92fjc0000gn/T/.tmpk6OSKK/.tmpH8pwU4\":
Os { code: 24, kind: Uncategorized, message: \"Too many open files\" }")',
datafusion/core/tests/fuzz_cases/order_spill_fuzz.rs:95:63
And the following warning during compilation:
*warning**: function `decimal_to_str` is never used*
*--> *datafusion/sqllogictest/src/engines/conversion.rs:85:15
*|*
*85* *|* pub(crate) fn decimal_to_str(value: Decimal) -> String {
*| * *^^^^^^^^^^^^^^*
*|*
*= **note*: `#[warn(dead_code)]` on by default
Op zo 13 aug 2023 om 13:36 schreef Andrew Lamb <al...@influxdata.com>:
> +1 (binding)
>
> Tested on mac x86_64
>
> Thank you for keeping the code flowing Andy
>
> Andrew
>
> On Sun, Aug 13, 2023 at 1:48 AM vin jake <jakevin...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > Verified on M1 Mac.
> >
> > Thanks Andy!
> >
> > On Sat, Aug 12, 2023, 01:59 Andy Grove <andygrov...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > I would like to propose a release of Apache Arrow DataFusion
> > > Implementation,
> > > version 29.0.0.
> > >
> > > This release candidate is based on commit:
> > > 8265e99d05382fca57cc7399f8ee241966f4a1f5 [1]
> > > The proposed release tarball and signatures are hosted at [2].
> > > The changelog is located at [3].
> > >
> > > Please download, verify checksums and signatures, run the unit tests,
> and
> > > vote
> > > on the release. The vote will be open for at least 72 hours.
> > >
> > > Only votes from PMC members are binding, but all members of the
> community
> > > are
> > > encouraged to test the release and vote with "(non-binding)".
> > >
> > > The standard verification procedure is documented at
> > >
> > >
> >
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > .
> > >
> > > [ ] +1 Release this as Apache Arrow DataFusion 29.0.0
> > > [ ] +0
> > > [ ] -1 Do not release this as Apache Arrow DataFusion 29.0.0 because...
> > >
> > > Here is my vote:
> > >
> > > +1
> > >
> > > [1]:
> > >
> > >
> >
> https://github.com/apache/arrow-datafusion/tree/8265e99d05382fca57cc7399f8ee241966f4a1f5
> > > [2]:
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-29.0.0-rc1
> > > [3]:
> > >
> > >
> >
> https://github.com/apache/arrow-datafusion/blob/8265e99d05382fca57cc7399f8ee241966f4a1f5/CHANGELOG.md
> > >
> >
>
--
Daniël Heres
