Am I reading the ticket correctly that this is also about importing some of the Dremio code into Arrow project (namely https://github.com/dremio/flightsql-odbc/). If it is the case, let me check how my company can provide the documentation for the project?
On Fri, Dec 8, 2023 at 8:41 AM David Li <lidav...@apache.org> wrote: > Thanks for the clarification. That does sound like a nontrivial amount of > code. > > My worry is that we might not be able to get all the paperwork necessary > from Amazon/Amazon contributors for the Timestream part. The > document/guidelines are here [1]. Does that look doable from your end? > > [1]: https://incubator.apache.org/ip-clearance/ > > On Thu, Dec 7, 2023, at 14:30, Alina Li wrote: > > Hi David. To be one the safer side, I suggest going through IP > > clearance for [3] the Timestream ODBC driver project, and more code > > than entry_points.cpp will be used. We have initially plan to use the > > Timestream's entry points code, but it includes more than just > > entry_points.cpp (code such as [5] odbc.cpp, [6] odbc.h and some other > > files are part of the entry points), and besides the entry points, > > we're planning to use Timestream's installers and DSN window as well. > > Sorry for the confusion. > > > > [5]: > > > https://github.com/awslabs/amazon-timestream-odbc-driver/blob/main/src/odbc/src/odbc.cpp > > [6]: > > > https://github.com/awslabs/amazon-timestream-odbc-driver/blob/main/src/odbc/include/timestream/odbc.h > > ________________________________ > > From: David Li <lidav...@apache.org> > > Sent: Wednesday, December 6, 2023 6:09 AM > > To: dev@arrow.apache.org <dev@arrow.apache.org> > > Subject: Re: [Discussion][C++][FlightRPC] What stage to submit a PR for > > Flight SQL ODBC driver > > > > Thanks for the update, Alina. This sounds good, my only question for > > the broader community is whether there is enough imported code that we > > should go through the IP clearance process [1]. It's never been clear > > to me what exactly the threshold for this is. flightsql-odbc [2] is > > already quite large on its own and probably we should go through > > clearance? It's not clear to me how much of the Timestream project [3] > > would be involved here, if you mean literally only entry_points.cpp [4] > > (that's probably OK without clearance?) or more code than that. > > > > [1]: https://incubator.apache.org/ip-clearance/ > > [2]: https://github.com/dremio/flightsql-odbc > > [3]: https://github.com/awslabs/amazon-timestream-odbc-driver > > [4]: > > > https://github.com/awslabs/amazon-timestream-odbc-driver/blob/main/src/odbc/src/entry_points.cpp > > > > On Tue, Dec 5, 2023, at 18:25, Alina Li wrote: > >> Hi community, > >> > >> I wanted to start a discussion regarding the development of Flight SQL > >> ODBC driver. Regarding the seed usage to my previous email, our initial > >> plan is that flightsql-odbc will be mostly used as-is other than > >> changes to conforming to Arrow coding guidelines, and for Amazon > >> Timestream driver, only its ODBC function entry code will be used and > >> adapted to call into flightsql-odbc classes. Please let me know if > >> there are any concerns around this. > >> > >> And from my discussion with David Li at > >> GH-30622<https://github.com/apache/arrow/issues/30622>, my > >> understanding is that the PR submission should be as early as possible. > >> We plan to send out a PR that adds Timestream ODBC driver and > >> flightsql-odbc seeds into Arrow if there's no concerns. The seed > >> drivers might not be able to compile, but the community would then be > >> able to start the IP scanning process. > >> > >> Your feedback would be appreciated, > >> > >> Alina Li > >> > >> ________________________________ > >> From: Alina Li <alina...@improving.com.INVALID> > >> Sent: Thursday, November 30, 2023 11:09 AM > >> To: dev@arrow.apache.org <dev@arrow.apache.org> > >> Subject: [C++][FlightRPC] Email regarding the ODBC driver > >> > >> Hi community, > >> > >> This email is regarding GitHub > >> issue#30622<https://github.com/apache/arrow/issues/30622>. We are > >> looking to build a new ODBC driver for Flight SQL that can be part of > >> the Arrow project. It would utilize parts of the Amazon Timestream ODBC > >> driver<https://github.com/awslabs/amazon-timestream-odbc-driver> and > >> the Flight SQL ODBC driver<https://github.com/dremio/flightsql-odbc> > >> (written by Dremio), which are Open Source and Apache 2.0-licensed. > >> Please let me know if you have any questions/comments. > >> > >> Cheers, > >> Alina >
