Hi, I think (2) is better because https://arrow.apache.org/docs/developers/java/building.html is for building checked out repository instead of a release source archive.
Thanks, -- kou In <CAB8EV3SgjXgbwS2-OGK=wojvxf+1pjtn_rpxq1eyourx-oi...@mail.gmail.com> "Re: [DISCUSS] Fix Arrow Flight Core tests" on Wed, 13 Dec 2023 20:42:29 +0100, Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > That's my point: > 1. we should document that the build has to be launched with > -DskipTests by default > 2. or include submodule in the source distribution we distributed > > I think (1) is an acceptable and easy path. If there are no > objections, I will create a PR about that (also updating > https://arrow.apache.org/docs/developers/java/building.html). > > Thoughts ? > > Thanks ! > Regards > JB > > On Wed, Dec 13, 2023 at 8:19 PM David Li <lidav...@apache.org> wrote: >> >> Could we include submodules in the source distribution instead? >> >> Also, you can still build from the source distribution, you just have to >> -DskipTests. >> >> On Wed, Dec 13, 2023, at 09:54, Jean-Baptiste Onofré wrote: >> > Hi David and foxes, >> > >> > I checked the release source distribution and I think we should maybe >> > include a profile to include TestTls related tests. >> > >> > As an Apache project, we are supposed to be able to build from the >> > source distribution without any external requirements (in the case the >> > project goes to the attic or someone wants to create a new release on >> > an old branch). >> > >> > Downloading >> > https://dist.apache.org/repos/dist/release/arrow/arrow-14.0.1/apache-arrow-14.0.1.tar.gz >> > and trying to build with: >> > >> > mvn clean install >> > >> > fails as git submodule is required. >> > >> > So, I would propose to: >> > 1. Exclude TestTls related tests by default >> > 2. Add a new profile (tlsTests) including TestTls tests >> > 3. Activate the profile on CI (-PtlsTests) >> > >> > Thoughts ? >> > >> > Regards >> > JB >> > >> > >> > On Mon, Dec 11, 2023 at 3:00 PM David Li <lidav...@apache.org> wrote: >> >> >> >> You can `git submodule update --init` to get the files. This is >> >> documented in the environment setup [1], though the failing assertion >> >> could be more helpful about pointing this out. >> >> >> >> [1]: >> >> https://arrow.apache.org/docs/dev/developers/java/building.html#building >> >> >> >> On Mon, Dec 11, 2023, at 08:49, Jean-Baptiste Onofré wrote: >> >> > Hi guys, >> >> > >> >> > I noticed that Arrow Flight Core doesn't build "out of the box" due to >> >> > the TestTls failing. >> >> > The reason what TestTls is failing is because it tries to read >> >> > cert0.pem from the testing/data folder (at project root), but testing >> >> > is empty by default. >> >> > If I create a cert0.pem by hand (with self signing key), it works. >> >> > >> >> > So, I propose three options: >> >> > 1. We document the required tests to build Arrow java cleanly >> >> > 2. We create a default self signed cert0.pem in testing/data that we >> >> > commit. >> >> > 3. We add a before step to the test to create the pem file >> >> > >> >> > My preference would be for 3. >> >> > >> >> > Thoughts ? >> >> > >> >> > Regards >> >> > JB
