+1 (binding) Agreed with Andrew. This looks like a test only issue. I think we should address the Expr PartialOrd further (https://github.com/apache/arrow-datafusion/issues/8932), but it should not block the release.
Thanks Andy. On Sun, Jan 21, 2024 at 3:13 AM Andrew Lamb <al...@influxdata.com> wrote: > > +1 (binding) > > I verified it on Mac (M3). > > I got the same error in test_partial_ord and I agree it looks very much the > the same as https://github.com/apache/arrow-datafusion/pull/8908 -- a test > only issue that should not block the release > > Thanks Andy > > > On Sat, Jan 20, 2024 at 10:43 AM Andy Grove <andygrov...@gmail.com> wrote: > > > Hi, > > > > I would like to propose a release of Apache Arrow DataFusion > > Implementation, > > version 35.0.0. > > > > This release candidate is based on commit: > > e58446bbe9ebe3f5a2aae1abd3c17a694070b0d1 [1] > > The proposed release tarball and signatures are hosted at [2]. > > The changelog is located at [3]. > > > > Please download, verify checksums and signatures, run the unit tests, and > > vote > > on the release. The vote will be open for at least 72 hours. > > > > Only votes from PMC members are binding, but all members of the community > > are > > encouraged to test the release and vote with "(non-binding)". > > > > The standard verification procedure is documented at > > > > https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates > > . > > > > [ ] +1 Release this as Apache Arrow DataFusion 35.0.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache Arrow DataFusion 35.0.0 because... > > > > Here is my vote: > > > > +1 > > > > [1]: > > > > https://github.com/apache/arrow-datafusion/tree/e58446bbe9ebe3f5a2aae1abd3c17a694070b0d1 > > [2]: > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-35.0.0-rc1 > > [3]: > > > > https://github.com/apache/arrow-datafusion/blob/e58446bbe9ebe3f5a2aae1abd3c17a694070b0d1/CHANGELOG.md > >
