+1 (binding) I'm gonna give the Go impl another review and once over, but in general it looks good and the Idea is sound.
On Thu, Mar 21, 2024, 10:12 AM Andrew Lamb <al...@influxdata.com> wrote: > +1 (binding) > > I reviewed the spec proposal and the rust implementation and I think they > look good to go. I am not as confident on the golang implementation, but > the comments on the Go PR look like there are no objections. > > Thank you for your work driving this forward > > Andrew > > On Wed, Mar 20, 2024 at 10:04 PM Adam C <adam.curtis....@gmail.com> wrote: > > > Hello, > > > > I would like to propose a change to the FlightSQL specification as > > originally described in this Github issue [1] by Andrew Lamb. The > > specification change would allow servers to support prepared > > statements with parameters, without needing to manage state between > > client requests. > > > > There is a draft pull request [2] submitted by me that updates the > > protobuf format and documents the changes made in the FlightSQL > > specification. I have also created draft reference implementations for > > the Go [3] and Rust [4] FlightSQL libraries. These implementations > > will be submitted as pull requests once the proposal is officially > > adopted. > > > > The vote will be open for at least 72 hours. > > > > [ ] +1 Release this as Apache Arrow Rust > > [ ] +0 > > [ ] -1 Do not release this as Apache Arrow Rust because... > > > > Cheers, > > Adam Curtis > > > > [1]: > > https://github.com/apache/arrow/issues/37720 > > [2]: > > https://github.com/apache/arrow/pull/40243 > > [3]: > > https://github.com/apache/arrow/pull/40311 > > [4]: > > https://github.com/apache/arrow-rs/pull/5433 > > >