Murtadha Hubail has posted comments on this change. Change subject: This change reduce object creation and instead re-use objects when doing inserts, deletes or searches in btrees and rtrees. ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Just one tiny comment. Will +2 after rebase. I hope the optimizations of this change outweigh the weird looking code :-) https://asterix-gerrit.ics.uci.edu/#/c/245/2/hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java: Line 286: // is there a case where cmp != pqCmp ?? I believe so. Because both cmp and pqCmp have protected modifier, they could be changed without using this method. You may remove this comment. -- To view, visit https://asterix-gerrit.ics.uci.edu/245 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fab280372951522db02f8c2ff1d7d5b15529cd7 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
