Ian Maxon has posted comments on this change. Change subject: Added the UUID constructor and changed the relevant documentation ......................................................................
Patch Set 3: Code-Review+1 (6 comments) Sorry for taking a bit :) Looks pretty good, just a few thoughts. https://asterix-gerrit.ics.uci.edu/#/c/326/3/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDFromStringConstructorDescriptor.java File asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/constructors/AUUIDFromStringConstructorDescriptor.java: Line 45: */ Not sure how all the indentation got changed to tabs. It should be 3 spaces I believe. Line 104: msb <<= 16; The 9 here is kind of 'magic', hard to know it's actually skipping the hyphen. Can we add a comment or have it be offset += 8; offset+=1 or similar?. Line 111: msb <<= 16; Shouldn't this be msb <<=8? Line 150: tmpLongVal = tmpLongVal * 16 + tmpIntVal; Why *16? Line 156: System.out.println(""); This doesn't belong here. Line 161: private int transformHexCharToInt(byte val) Cool. This should be fast hopefully. I believe switch/cases beyond a certain size get turned into branch tables in good compilers. -- To view, visit https://asterix-gerrit.ics.uci.edu/326 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2276bf2b44975b13c99d56f448ae3e9e4a74b04e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
