Chris Hillery has posted comments on this change.

Change subject: Change Nexus repo, relax RAT checks
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

See comment in pom.xml. Also, the commit message should probably mention the 
updated <scm> block.

https://asterix-gerrit.ics.uci.edu/#/c/332/2/pom.xml
File pom.xml:

Line 158:         
<connection>scm:git:ssh://[email protected]:apache/incubator-asterixdb.git</connection>
Shouldn't we use the git://github.com/ form here? Using ssh: means only people 
with GitHub accounts and ssh keys will be able to pull.

Unfortunately I don't think there's an equivalent git:// URL for Gerrit...


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/332
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9fe685a912df7b18e59579c832eea0dbbeb18b3f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Chris Hillery <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-HasComments: Yes

Reply via email to