Steven Jacobs has posted comments on this change. Change subject: Changed metadata storage format for nullable field types. Moved field name generation to the client out of metadata node code. Changed naming scheme for autogenerated types. ......................................................................
Patch Set 3: (1 comment) Forgot to commit this comment that I wrote previously https://asterix-gerrit.ics.uci.edu/#/c/323/3/asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/bootstrap/MetadataPrimaryIndexes.java File asterix-metadata/src/main/java/edu/uci/ics/asterix/metadata/bootstrap/MetadataPrimaryIndexes.java: Line 116: > Wait though, this still doesn't look right. Why was this commented out? It' This is because there seem to be a few cases of dead feed activity code that Raman missed. There are a few of these fixes in Heri's code review as well as on my channel branch. Feed Activity is no longer part of metadata as of feeds 2.0 -- To view, visit https://asterix-gerrit.ics.uci.edu/323 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I223aded8aaf80f0688358899c0e8b0d6988fac93 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
