Ian Maxon has posted comments on this change. Change subject: This change includes: 1. avoid calling ByteBuffer.get() and ByteBuffer.put() for bloom filter set/get operations. ByteBuffer will check boundaries of the index for get/put. It's a very frequent operation. 2. let the hash table size in BufferCache be 3X of ......................................................................
Patch Set 1: Code-Review+2 It seems fine to me. Honestly, it should probably be a parameter that's exposed via asterix-configuration.xml, but making it 3 isn't making the situation any worse. -- To view, visit https://asterix-gerrit.ics.uci.edu/345 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd47c410338ce557a494ab3605660bad1899e786 Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: No
