Ian Maxon has posted comments on this change. Change subject: Allow lazy loading for persistent local resources ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Just a few thoughts... https://asterix-gerrit.ics.uci.edu/#/c/344/2/asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java File asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java: Line 98: Why the change of order here? https://asterix-gerrit.ics.uci.edu/#/c/344/2/asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java File asterix-transactions/src/main/java/edu/uci/ics/asterix/transaction/management/service/recovery/RecoveryManager.java: Line 279: index = (ILSMIndex) indexLifecycleManager.getIndex(localResource.getResourceName()); Won't this act differently now, if the local resource doesn't exist? If the resource doesn't exist, the map will return null, and you'll get a NPE when calling localResource.getName(), instead of having index get set to null. -- To view, visit https://asterix-gerrit.ics.uci.edu/344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b9260a3280750145f6ddb3783673a299055910 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
