Taewoo Kim has posted comments on this change.

Change subject: Optimized the binary tokenizer - get the total number of tokens 
Change-Id: Ifa9a18a43a097766da22633bb48371ffc78406ae
......................................................................


Patch Set 2:

(1 comment)

Thanks Young-Seok. I have applied your comment and am going to upload the 
revised code soon.

https://asterix-gerrit.ics.uci.edu/#/c/348/2/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/tokenizers/DelimitedUTF8StringBinaryTokenizer.java
File 
hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/edu/uci/ics/hyracks/storage/am/lsm/invertedindex/tokenizers/DelimitedUTF8StringBinaryTokenizer.java:

Line 82:             boolean previousCharIsNonSeparator = false;
> It seems easier to change the above variable to previousCharIsSeparator ins
Good point. Applied.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/348
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa9a18a43a097766da22633bb48371ffc78406ae
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Young-Seok Kim <[email protected]>
Gerrit-HasComments: Yes

Reply via email to