Ildar Absalyamov has posted comments on this change. Change subject: Changed metadata storage format for nullable field types. Moved field name generation to the client out of metadata node code. Changed naming scheme for autogenerated types. Moved GroupName, CompactionPolicy & CompactionPolicyProperties fields up from Ext ......................................................................
Patch Set 10: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/323/10/asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 199: } > Why are those candidates removed? Could we add a comment? That's the hackish solution introduced initially by Abdullah, and reused here for my needs. It removes secondary metadata indexes from consideration, because they do no provide the valid types for indexed fields, thus breaking type validation logic underneath. I am not a big fan of this solution, but this is as far as I can get without redesigning secondary metadata indexes implementation. -- To view, visit https://asterix-gerrit.ics.uci.edu/323 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I223aded8aaf80f0688358899c0e8b0d6988fac93 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
