Yingyi Bu has posted comments on this change. Change subject: Adapted Inline Variable rules to allow exceptions for nonfunctional functions. Exceptions must be implemented by an inherited class. ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/368/1/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java: Line 137: || (!funcExpr.isFunctional() && !createException(expr))) { What does createException(...) mean here? Why does it always return false? -- To view, visit https://asterix-gerrit.ics.uci.edu/368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib990773ec36a3f51abef72ce6ceb7715aa1d5e37 Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
