Ian Maxon has posted comments on this change. Change subject: Introduced Local Filesystem Feed Adapter ......................................................................
Patch Set 3: (3 comments) Just a few thoughts. Cool overall though! I'll try it myself soon... https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-app/src/test/resources/runtimets/testsuite.xml File asterix-app/src/test/resources/runtimets/testsuite.xml: Line 25: <test-group name="external"> Nit: spaces instead of tabs would be good :) https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java: Line 120: } Is it really the case, that no matter what exception we may eat here, we still want to continue?... https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java: Line 319: String[] builtInAdapterClassNames = new String[] { > All of these need to be changed to dynamic class names. e.g. LocalFileSyste +1 ;) But there's lots of other places in the code that are equally guilty of this. -- To view, visit https://asterix-gerrit.ics.uci.edu/376 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707756e3b4c9ffca4b55ec9817a08e5c16333010 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
