Chris Hillery has posted comments on this change. Change subject: This change fixes the sporadic connection refused errors after managix starts up an Asterix instance. This can mostly be seen during asterix-installer tests. The fix basically lets managix wait and listens through zookeeper for a signal from the cluster c ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java: Line 119: feedServer.join(); Should there be code here to update Zookeeper that the cluster is now down? https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java File asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java: Line 152: clusterProperties.add(new Property("MANAGIX_IP", InetAddress.getLocalHost().getHostAddress())); Similar to comment on Hyracks change - shouldn't this be ZOOKEEPER_IP ? Line 186: private static void injectAsterixLogPropertyFile(String asterixInstanceDir, AsterixInstance asterixInstance) Sure, delete it. https://asterix-gerrit.ics.uci.edu/#/c/366/2/asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java File asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java: Line 46: public ClusterState getClusterState() throws Exception { I think this method should be called something like "waitForClusterStart()". The current name doesn't imply that it will block until something happens. It also implies that it's a more general accessor than it is. Line 63: public void monitorStateChange() { Could this method be private? We don't want anyone calling it except the monitoring thread, right? -- To view, visit https://asterix-gerrit.ics.uci.edu/366 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib730f50ab2fb492f3cf973d1cf2f03b34e24e5b3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Chris Hillery <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
