+1
On 2 Nov 2015, at 12:21, Murtadha Hubail wrote:
Even thought it says 8 in the POM, it doesn’t force you to use it.
Currently, it looks for the highest JDK version available and use it.
I think we should change it to force you to use 8 now since we have
used JDK 8 features in the code. That way the error message will be
much more clearer :-)
Ian said that this change is easy to do.
-Murtadha
On Nov 2, 2015, at 12:12 PM, Steven Jacobs <[email protected]> wrote:
Got it, Thanks (I was using 7 still)!
Steven
On Mon, Nov 2, 2015 at 11:48 AM, Yingyi Bu <[email protected]>
wrote:
All right, great!
Best,
Yingyi
On Mon, Nov 2, 2015 at 11:46 AM, Till Westmann <[email protected]>
wrote:
I think that we’re on 8 (that’s what my pom.xml says) and I
also think
that we should be Java 8 only as Java 7 is not supported anymore
since
April 2015 [1].
Cheers,
Till
[1] https://www.java.com/en/download/faq/java_7.xml
On 2 Nov 2015, at 11:36, Yingyi Bu wrote:
Yes, I think it's because my change depends on a default interface
method
implementation.
I thought we had moved to Java 8.
Do I need to add a fix for that so that we can build with Java 7
as
well?
Best,
Yingyi
On Mon, Nov 2, 2015 at 11:28 AM, Chris Hillery
<[email protected]>
wrote:
Do we depend on default interface method implementations? That
feature
was
only introduced with Java 8.
What version of the JDK are you using, Till and Steven?
Ceej
aka Chris Hillery
On Nov 2, 2015 11:22 AM, "Till Westmann" <[email protected]>
wrote:
That is indeed strange. I’m using maven 3.3.3 on OS X and it
builds
fine.
Also, in my JDK the Iterator interface has a default
implementation
for
the remove method.
So there should no be a reason to provide a remove method for an
iterator.
On 2 Nov 2015, at 10:57, Steven Jacobs wrote:
Is any one else having trouble building master? I've updated
maven to
3.3.3
but I get a strange error now from asterix-lang-common:
[INFO] 1 error
[INFO]
-------------------------------------------------------------
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] asterix ............................................
SUCCESS [
29.003 s]
[INFO] asterix-test-framework .............................
SUCCESS [
4.790 s]
[INFO] asterix-common .....................................
SUCCESS [
5.980 s]
[INFO] asterix-maven-plugins ..............................
SUCCESS [
0.092 s]
[INFO] record-manager-generator-maven-plugin ..............
SUCCESS [
2.629 s]
[INFO] asterix-transactions ...............................
SUCCESS [
2.733 s]
[INFO] asterix-om .........................................
SUCCESS [
3.718 s]
[INFO] asterix-fuzzyjoin ..................................
SUCCESS [
1.940 s]
[INFO] lexer-generator-maven-plugin .......................
SUCCESS [
1.726 s]
[INFO] asterix-runtime ....................................
SUCCESS [
5.355 s]
[INFO] asterix-events .....................................
SUCCESS [
3.605 s]
[INFO] asterix-metadata ...................................
SUCCESS [
3.965 s]
[INFO] asterix-lang-common ................................
FAILURE [
4.162 s]
[INFO] asterix-lang-aql ...................................
SKIPPED
[INFO] asterix-lang-sqlpp .................................
SKIPPED
[INFO] asterix-external-data ..............................
SKIPPED
[INFO] asterix-algebra ....................................
SKIPPED
[INFO] asterix-tools ......................................
SKIPPED
[INFO] asterix-app ........................................
SKIPPED
[INFO] asterix-examples ...................................
SKIPPED
[INFO] asterix-server .....................................
SKIPPED
[INFO] asterix-installer ..................................
SKIPPED
[INFO] asterix-doc ........................................
SKIPPED
[INFO] asterix-yarn .......................................
SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:10 min
[INFO] Finished at: 2015-11-02T10:53:54-08:00
[INFO] Final Memory: 163M/904M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
(default-compile) on project asterix-lang-common: Compilation
failure
[ERROR]
/Users/stevenjacobs/asterix/asertixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/context/Scope.java:[161,42]
error: <anonymous
org.apache.asterix.lang.common.context.Scope$1> is
not
abstract and does not override abstract method remove() in
Iterator
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven
with
the
-e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug
logging.
[ERROR]
[ERROR] For more information about the errors and possible
solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build
with
the
command
[ERROR] mvn <goals> -rf :asterix-lang-common
Steven