Hi All, Today, I implemented a fix for a critical issue that we have and wanted to add a new kind of test cases where the test case has 3 files:
1. Creating the dataset. 2. Fill it with data that have duplicate keys. This is expected to throw a duplicate key exception. 3. Delete the dataset. This is expected to pass (the bug was here where it is not being deleted). With the current way we use the test framework, we are unable to test such case and so I started to improve the test framework starting with actually checking the type of exception thrown and making sure that it matches the expected error. ... and boom. I found that many test cases fail but nobody notices because no one checks the type of exception thrown. Moreover, If a test is expected to fail and it doesn't, the framework doesn't check for that. In addition, sometimes the returned exception is meaningless and that is something we absolutely must avoid. What I propose is that I push to master the improved test framework and disable the failing test cases, create JIRA issues for them and assign each to someone to look at them. Thoughts? Amoudi, Abdullah.
