----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59799/#review178780 -----------------------------------------------------------
notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java Lines 51 (patched) <https://reviews.apache.org/r/59799/#comment252964> "newKafkaConsumer" ==> "kafkaConsumer" notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java Lines 63 (patched) <https://reviews.apache.org/r/59799/#comment253027> "List" ==> "List<T>" - since the return type of this method is "List<T>". This update would require bunch of other updates..which endup with inconsistencies in types returned/expected. Please review. - Madhan Neethiraj On June 21, 2017, 1:11 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59799/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 1:11 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This patch include changes that implements kafka new-consumer api for > kafkaConsumer for Atlas Notification System. > > > Diffs > ----- > > distro/src/conf/atlas-application.properties 5e59528 > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > PRE-CREATION > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java > PRE-CREATION > notification/src/main/java/org/apache/atlas/kafka/KafkaConsumer.java > 16c0eb2 > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java > 8bd31fd > > notification/src/main/java/org/apache/atlas/notification/AbstractMessageDeserializer.java > 9585827 > > notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java > d4d78de > > notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java > a99cb10 > notification/src/test/java/org/apache/atlas/kafka/KafkaConsumerTest.java > ad7d93e > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationMockTest.java > 2126be6 > > notification/src/test/java/org/apache/atlas/kafka/KafkaNotificationTest.java > a810029 > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 13f2f0b > typesystem/src/test/resources/atlas-application.properties c4ce5ea > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 2f8245d > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > ac3b538 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > 18fd2ee > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > bdb60a2 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > b59d3ee > > webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java > 310b2e3 > > webapp/src/test/java/org/apache/atlas/web/integration/EntityV2JerseyResourceIT.java > 98a7abc > > > Diff: https://reviews.apache.org/r/59799/diff/4/ > > > Testing > ------- > > Tested Kafka consumer on local embeded kafka /zookeeper env. > Tested Atlas Hive hook notifications. > Excecute Quick Start script. > > Due to change in kafkaconsumer api the current notification related UT/IT's > need to changed, i have not included this change in this patch but will > included it shortly. > > > Thanks, > > Nixon Rodrigues > >
