> On July 4, 2017, 10:39 a.m., David Radley wrote: > > client/src/main/java/org/apache/atlas/AtlasBaseClient.java > > Lines 235 (patched) > > <https://reviews.apache.org/r/60603/diff/1/?file=1768502#file1768502line235> > > > > I wonder whether the fix to enable Knox integration should be for Atlas > > to add the generic ability to set Headers in the Atlas Client. > > > > Instead I suggest: > > As we handle userid and passwords for the client, I suggest that we do > > not expose setHeaders ( a low level http orientated method) instead we > > expose a method like setKnoxSSOCookie; I think this would give the atlas > > client developer a clue as to why they might want to use this method; also > > it would not expose other low level http control functionality as a side > > effect.
Thanks David, that's good feedback. I think I've duplicated the effort that Nixon was already working on. His review does have the ability to add cookies to the request. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60603/#review179558 ----------------------------------------------------------- On July 3, 2017, 5:16 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60603/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 5:16 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1906 > https://issues.apache.org/jira/browse/ATLAS-1906 > > > Repository: atlas > > > Description > ------- > > New capability exposed under V1 and V2 client. > ```java > setHeader(String name, String value) > setHeaders(Map<String, String> headers) > ``` > > PS: Due to code rearrangement the diff is much bigger > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e3 > > > Diff: https://reviews.apache.org/r/60603/diff/1/ > > > Testing > ------- > > Setting custom header(s) was successful > > > Thanks, > > Apoorv Naik > >
