----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60627/#review179657 -----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java Lines 136 (patched) <https://reviews.apache.org/r/60627/#comment254467> how do we know that the supplied cookie is the knox one? I suggest we validate that it is the cookie we are interested in. I assume we want to reject the request if it is not the knox one. client/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 139 (patched) <https://reviews.apache.org/r/60627/#comment254465> haddop => hadoop common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java Lines 53 (patched) <https://reviews.apache.org/r/60627/#comment254466> should the error message relate to knox enabled not Kerberos? - David Radley On July 5, 2017, 2:37 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60627/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 2:37 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Sarath Subramanian, and Hemanth Yamijala. > > > Bugs: ATLAS-1906 > https://issues.apache.org/jira/browse/ATLAS-1906 > > > Repository: atlas > > > Description > ------- > > This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as > authentication header for Atlas. > > Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will > overload the Atlas Client constructor to support Knox SSO cookie by adding > below constructor. > > AtlasClient(atlasURL, cookieName, CookieValue, path, domain); > AtlasClient(atlasURL, Cookie); > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e > client/src/main/java/org/apache/atlas/AtlasClient.java ec482da > client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 > > > Diff: https://reviews.apache.org/r/60627/diff/3/ > > > Testing > ------- > > Unit test cases are running fine using mvn clean install. > Ran Quick Start and Atlas admin script using the new Atlasclient Constructor. > > AltasClient(atlasUrl, new Cookie("hadoop-jwt" , > "eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM"); > > > Thanks, > > Nixon Rodrigues > >
