----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60927/#review180908 -----------------------------------------------------------
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java Lines 29 (patched) <https://reviews.apache.org/r/60927/#comment256251> Minor point but it would be nicer to name this parameter 'vertices' for consistency with other changes. graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java Lines 91 (patched) <https://reviews.apache.org/r/60927/#comment256252> Trailing whitespace. graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java Lines 80 (patched) <https://reviews.apache.org/r/60927/#comment256250> I'm slightly worried because the multiQuery() method appears to be deprecated (in Titan 1.0.0). Presumably that suggests there is a better way to do this with Titan, although I'm not sure what. I suspect we need to construct the MVQ explicitly rather than pass the vertex or Collection to multiQuery(). graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java Lines 396 (patched) <https://reviews.apache.org/r/60927/#comment256253> Should this be accepting (and transforming) an edges parameter? - Graham Wallis On July 17, 2017, 10:31 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60927/ > ----------------------------------------------------------- > > (Updated July 17, 2017, 10:31 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > Initial draft for multi-vertex graph query in atlas > > > Diffs > ----- > > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java > dded76f8 > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasMultiVertexQuery.java > PRE-CREATION > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanMultiVertexQuery.java > PRE-CREATION > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanQueryFactory.java > ac7ff9e8 > graphdb/titan0/pom.xml ceda1bb2 > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > 2408287b > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/Titan0AtlasMultiVertexQuery.java > PRE-CREATION > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > ffb6b37f > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/Titan1AtlasMultiVertexQuery.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 77b2c7c2 > > > Diff: https://reviews.apache.org/r/60927/diff/1/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > >
