----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60971/#review180948 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 2:22 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60971/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 2:22 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-1914 > https://issues.apache.org/jira/browse/ATLAS-1914 > > > Repository: atlas > > > Description > ------- > > This patch handles following use cases. > > * Clicking on clear button will clear all filters for type and tag. > * Prevent attribute popup to be closed, if values are empty. > * Allow to close popup if all attributes are cleared. > * If tag is deleted then hash will be flushed. > > > Diffs > ----- > > dashboardv2/public/js/router/Router.js 8a1d241 > dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js 013c72e > dashboardv2/public/js/views/search/QueryBuilderView.js 468a2d7 > dashboardv2/public/js/views/search/SearchLayoutView.js cb8844d > dashboardv2/public/js/views/tag/TagLayoutView.js b8a1cd1 > > > Diff: https://reviews.apache.org/r/60971/diff/1/ > > > Testing > ------- > > All above scenario are tested. > > > Thanks, > > keval bhatt > >
