----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61234/#review181745 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java Lines 261 (patched) <https://reviews.apache.org/r/61234/#comment257394> Having a tolerant behvior, of ignoring unknown attributes, would be helpful. If V1 APIs rejected unknown attributes earlier, I would suggest to move this error only in V1 path. - Madhan Neethiraj On July 28, 2017, 9:47 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61234/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 9:47 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > Right now in the V2 API, if an entity update is performed with an invalid > attribute it's ignored and the entity gets updated > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > b8fd70e5 > > > Diff: https://reviews.apache.org/r/61234/diff/1/ > > > Testing > ------- > > Update JSON (POST on entity) with invalid attribute in the request results in > 400 > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
