----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61526/ -----------------------------------------------------------
Review request for atlas. Repository: atlas Description ------- ATLAS-2029: Restrict entities, classifications can be applied to Diffs ----- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 36fcc03c13ae8bee14815e11497e0ae3a6d6e2d2 intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java eeaf71413a56c08db8170fd3323b8e8245ae44fe intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38392d2d2c8882861373cd42a549b5670d intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 427439ca97d496f02de2d38329c582ded239c04c intg/src/test/java/org/apache/atlas/TestUtilsV2.java fc65af057255b4c17378080ee4fb7cbfc780c3fe repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 89445048c69555b86a5347b21dde5a21dae9b2a1 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1c168b4cff0d105c7a0d4a9fbdb50871388c917e repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 227f7cd12a9b23c3bbc1cfdc40d06616ea775ca4 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 50a421662b9a58ea3daf45e57d21626b5f2c6c44 repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 8638a7f17e8a17d3a6e0bfb94879b5c5406be1a3 Diff: https://reviews.apache.org/r/61526/diff/1/ Testing ------- Testing performed unit tests Using postman 1) create an entityDef aaa 2) create a classificationDef with an entitytype aaaa - checked that it is in the response 3) Create a entity instance of aaa 4) add the classification to it 5) Create an entity instance with a different type bbbb 6) Attempt to add the classification to bbbb. this fails with an informative message 7) Attempt to update the ClassificationDef to remove the entity type - this fails with an informative message 8) Attempt to update the classificationdef to add bbbb. this update works. 9) Attempt to add an entity type that does not exist to the ClassificationDef. this should fail. 9) Attempt to update an entity type that does not exist to the ClassificationDef. this should fail. 10) Create a ClassificationDef with no entitytypes as a subtype of another ClassificationDef. Ensure that the sub classification can be applied to entities specifed in the parent. Thanks, David Radley
