> On Aug. 16, 2017, 5:29 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > > Lines 128 (patched) > > <https://reviews.apache.org/r/61085/diff/1/?file=1781424#file1781424line134> > > > > David, > > > > You are effectively looking for edges with label > > 'AtlasRelationshipDef.RELATIONSHIP_PREFIX + relationshipType'. > > > > So instead of retrieving all edges and looking for label prefix > > 'AtlasRelationshipDef.RELATIONSHIP_PREFIX', followed by a substring() and > > equals(relationshipType) - wouldn't it be simpler to retrieve edges with > > the following call: > > > > vertex.getEdges(AtlasEdgeDirection.BOTH, > > AtlasRelationshipDef.RELATIONSHIP_PREFIX + relationshipType) > > > > Madhan
Hi Madhan, I had not thought of that - that is much simpler. Thanks :-) , all the best, David. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61085/#review183043 ----------------------------------------------------------- On July 24, 2017, 5:18 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61085/ > ----------------------------------------------------------- > > (Updated July 24, 2017, 5:18 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-1983: Add relationship cardinality validation > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java > b24f99f6f9337aa10f40e9f10024fe5a345c3540 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java > c17e875d10169753b76fcdb483e2ca85195104b2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 49e08a070a803a36253b502666947ab92ffe39d3 > > > Diff: https://reviews.apache.org/r/61085/diff/1/ > > > Testing > ------- > > ran Junits > Successfully added one relationship, then added a second which resulted in > the error. > > > Thanks, > > David Radley > >
