[ 
https://issues.apache.org/jira/browse/ATLAS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130978#comment-16130978
 ] 

Sarath Subramanian commented on ATLAS-2050:
-------------------------------------------

[~davidrad], addressed some review comments

1. Removed debug logs - this is a helper method and the caller can issue the 
debug log
2. this is not a static method 
3. if attributeName is null, end1Type.getAttribute(null) will return null and 
I'm handling null in the return statement - added safety net null check for 
attributeName in updated review.
4. This was added as additional safety check, removed it.
5. This can be used by other methods - to get edge label valid values should be 
null/valid edge label. The caller should handle exception messages.

> Add helper method in relationship store to check if entity has relationship 
> associated
> --------------------------------------------------------------------------------------
>
>                 Key: ATLAS-2050
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2050
>             Project: Atlas
>          Issue Type: Improvement
>          Components:  atlas-core
>    Affects Versions: trunk, 0.9-incubating
>            Reporter: Sarath Subramanian
>            Assignee: Sarath Subramanian
>            Priority: Minor
>             Fix For: trunk, 0.9-incubating
>
>         Attachments: ATLAS-2050.2.patch
>
>
> Add helper method in AtlasRelationshipStoreV1 to check whether entity vertex 
> has a relationship associated with a relationship type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to