----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61891/#review183770 -----------------------------------------------------------
Ship it! Ship It! - Apoorv Naik On Aug. 24, 2017, 6:56 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61891/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 6:56 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2085 > https://issues.apache.org/jira/browse/ATLAS-2085 > > > Repository: atlas > > > Description > ------- > > In HA deployments Atlas instances load bootstrap types during initialization > i.e. before leader election. When Atlas is brought up for the first time, > this will initialize the store with the types defined in the model files. > Index setup kicks in when an instance is activated - > GraphBackedSearchIndexer.initialize(); this looks for a specific property > name ('__type') in graph management and upon finding it, Atlas skips rest of > the initialization (creation of indexes like vertex_index, edge_index, > fulltext_index). This results in subsequent queries to fail with error > "vertex_index" not found. > > The fix is to defer loading of bootstrap types to instance-activation. Also, > added info level logs to trace type initialization and index creation > activities. > > > Diffs > ----- > > addons/models/0010-base_model.json 7f64d85e > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > eabd272e > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > 632b4790 > > repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java > 4530f51b > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 386b4936 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > a30c97ae > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java > 2a07f029 > > > Diff: https://reviews.apache.org/r/61891/diff/2/ > > > Testing > ------- > > Verified that Atlas starts up successfully in the following cases: > - Single instance, with an empty store (i.e. first time) > - Single instance, with non-empty store > - HA: multiple instances, with an empty store > - HA: multiple instances, with non-empty store > > > Thanks, > > Madhan Neethiraj > >
