> On Aug. 25, 2017, 7:18 p.m., Apoorv Naik wrote: > > dev-support/atlas-docker/Dockerfile > > Lines 52 (patched) > > <https://reviews.apache.org/r/61913/diff/1/?file=1803740#file1803740line52> > > > > Just curious as to why we're logging into hbase shell > > Madhan Neethiraj wrote: > I had the same question. > > I think it will be better to tail Atlas log file with: 'tail -fF > /root/atlas-bin/logs/application.log'. > > Rest of the patch is good. Thanks Nigel. > > Nigel Jones wrote: > purely a left over/oversight from hbase. I'll make that update and repost
Madhan made this change when committing it, so closing this review - Nigel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61913/#review183865 ----------------------------------------------------------- On Aug. 25, 2017, 2:14 p.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61913/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2017, 2:14 p.m.) > > > Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and > Richard Ding. > > > Repository: atlas > > > Description > ------- > > ATLAS-2012: Build docker image > > Note: Unit tests are currently not run within the docker image build process. > As per the JIRA it would be nice to include these but currently the tests > fail in many ways. This is an independent issue to the docker image work, and > so I propose opening a new JIRA to re-enable UT once build is stable, but > meanwhile we can get the docker support in > > > Diffs > ----- > > dev-support/atlas-docker/Dockerfile PRE-CREATION > dev-support/atlas-docker/README.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/61913/diff/1/ > > > Testing > ------- > > * check image can be rebuilt repeatedly > * checker Atlas image starts up correctly > * Run some unit tests in built image (note: see mailing list for discussion > about current IT test failures in builds) > * Verified Atlas Web UI is accessible > > > Thanks, > > Nigel Jones > >
