-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61980/#review184111
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Aug. 29, 2017, 4:22 p.m., Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61980/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 4:22 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2087
>     https://issues.apache.org/jira/browse/ATLAS-2087
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Allow users to use existing property "atlas.server.bind.address" to specify 
> an address Atlas server binds to. If not specified, the default address 
> "0.0.0.0" is used.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/Atlas.java e29254b0 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 467571e8 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
> fa02e9b9 
>   
> webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java
>  02a6fe40 
>   
> webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java
>  d46aa2f9 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
> ad87025d 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 95720fdf 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java
>  dc3b936b 
>   
> webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java
>  41c3cb1b 
> 
> 
> Diff: https://reviews.apache.org/r/61980/diff/1/
> 
> 
> Testing
> -------
> 
> All unit tests pass.
> 
> Tested with following configurations:
> ```
> atlas.server.bind.address=0.0.0.0
> 
> atlas.server.bind.address=127.0.0.1
> 
> atlas.server.bind.address=123.45.67.89
> 
> ```
> The last is an invalid address and the server will shutdown with an error 
> message.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Reply via email to