> On Sept. 1, 2017, 5:45 p.m., Madhan Neethiraj wrote: > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java > > Lines 38 (patched) > > <https://reviews.apache.org/r/59821/diff/3/?file=1809430#file1809430line38> > > > > Few fields seem redundant. Please review and remove fields that are not > > needed. > > > > nameSpace ==> namespaceDescriptor should have this info > > tableName ==> hTableDescriptor should have this info > > hColumnDescriptors, hColumnDescriptor: is one for column-family and > > other for column?
nameSpace is String object, namespaceDescriptor is object with namespace and addition info. I need to have this in HbaseOperationContext as different operation from Hbase sends either namespace or namespaceDescriptor and hence having this in hbaseOperationCOntext made it simple to refer. Also this allowed me to have a same method to be used, when message are created for namespace,table,columnfamily - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59821/#review184324 ----------------------------------------------------------- On Aug. 31, 2017, 10:52 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59821/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 10:52 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1805 > https://issues.apache.org/jira/browse/ATLAS-1805 > > > Repository: atlas > > > Description > ------- > > ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family > metadata to Atlas > > > Diffs > ----- > > addons/hbase-bridge-shim/pom.xml PRE-CREATION > > addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java > PRE-CREATION > addons/hbase-bridge/pom.xml PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java > PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java > PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java > PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java > PRE-CREATION > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java > PRE-CREATION > addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml > PRE-CREATION > > addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java > PRE-CREATION > addons/models/0060-hbase_model.json 3e46e06 > distro/src/main/assemblies/standalone-package.xml 215cb23 > pom.xml 8b9eee6 > > > Diff: https://reviews.apache.org/r/59821/diff/3/ > > > Testing > ------- > > * Review comments fixed with 2 exceptions whcih I have commented on > * Added an IT test > * Testing done in LOCAL VM > > > Thanks, > > Ramesh Mani > >
