> On Sept. 12, 2017, 6:15 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > > Lines 275 (patched) > > <https://reviews.apache.org/r/62244/diff/1/?file=1820214#file1820214line275> > > > > can we include descriptions for existing attributes and > > relationshipEndDefs for out of the box models as part of this JIRA?
I think it is better to separate the putting values into the models into separate Jiras. We can then use those Jiras to review the description content rather than the mechanism to introduce description. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62244/#review185223 ----------------------------------------------------------- On Sept. 12, 2017, 5:13 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62244/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 5:13 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > ATLAS2058 Add description to attributedefs and relationship enddefs > > > Diffs > ----- > > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java > 01e5ce738e8a5310cee928560364d4a38f5c6e18 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 3a5c43ac7e6d0a7f683c24d13d6c841de4d66a14 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > c3c42be86d8c9fd282fdc1428c8fd78e338a3cfb > > > Diff: https://reviews.apache.org/r/62244/diff/1/ > > > Testing > ------- > > Create an entity attribute, relationship attribute and a relationship end > with a description and then issue getTypeDefs to check they are there. > > > Thanks, > > David Radley > >
