----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62355/ -----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Mehul Parikh, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-2102, ATLAS-2103, ATLAS-2104, ATLAS-2105, ATLAS-2107, and ATLAS-2108 https://issues.apache.org/jira/browse/ATLAS-2102 https://issues.apache.org/jira/browse/ATLAS-2103 https://issues.apache.org/jira/browse/ATLAS-2104 https://issues.apache.org/jira/browse/ATLAS-2105 https://issues.apache.org/jira/browse/ATLAS-2107 https://issues.apache.org/jira/browse/ATLAS-2108 Repository: atlas Description ------- *ATLAS-2102* ====== 1. Previous and Next button should not be present is the number of search results is less than the current page size. 2. Search results table shifts visually if the show historical properties is selected (moves right and down by ~20px) needs to have a consistent position in the layout. 3. Remove edit entity action button from search Table. 4 . Place the pagination button at the bottom. 5. Add go to page functionality. 6. Add page size drop down. *ATLAS-2103* ====== 1. Change the color of notification *ATLAS-2104* ====== 1. Missing labels in Edit tag popup: A Tag could have the same Name and Description attribute values. In this case, when editing a tag, the Edit Description modal does not communicate that only "Description" attribute value is editable and "Name" is not editable. Also since the field does not have any label it is confusing as to what attribute is allowed to be modified on edit. It would be nice to prefix the attribute name to the edit dialogs for updating the value (i.e. show "Name :" and "Description :" as prefixes to the field values being edited so it is very clear which field is being edited. 2. Background color of Tag Delete popup confirmation can be improved to be a more neutral and lighter color. 3. In create tag pop up move "Add Attribute" button to the left side. *ATLAS-2105* ====== 1. Renaming search and apply button to search. 2. Change background color to white. *ATLAS-2107* ====== 1. The current design of the create entity modal dialog can be improved with small changes such as removing dividing lines, justifying the labels and making the dialog box to be have a more consistent look and feel. *ATLAS-2108* ====== Currently there is placeholder content in the help popup dialog for Advanced search. Placeholder need to be removed to make the help more useful and the placeholders need to be replaced with relevant content such as from Apache Atlas wiki for DSL search http://atlas.apache.org/Search.html Diffs ----- dashboardv2/public/css/scss/__mixin.scss PRE-CREATION dashboardv2/public/css/scss/breadcrumb.scss dbd17b4 dashboardv2/public/css/scss/business-catlog.scss 8e68fc1 dashboardv2/public/css/scss/form.scss 9989e7c dashboardv2/public/css/scss/graph.scss 3e55b96 dashboardv2/public/css/scss/loader.scss ff8b890 dashboardv2/public/css/scss/login.scss b917d46 dashboardv2/public/css/scss/main.scss 83c2a5a dashboardv2/public/css/scss/nav.scss 524e2b8 dashboardv2/public/css/scss/old-style.scss 89e313e dashboardv2/public/css/scss/override.scss e4e8bf7 dashboardv2/public/css/scss/profile-table.scss 2b0b483 dashboardv2/public/css/scss/search.scss 2bce210 dashboardv2/public/css/scss/style.scss f634c44 dashboardv2/public/css/scss/tab.scss 9b67e2c dashboardv2/public/css/scss/tag.scss 39bc995 dashboardv2/public/css/scss/theme.scss 5cf8848 dashboardv2/public/css/scss/tree.scss 50396ba dashboardv2/public/js/router/Router.js a43fbf7 dashboardv2/public/js/templates/audit/AuditTableLayoutView_tmpl.html ca9421d dashboardv2/public/js/templates/audit/CreateAuditTableLayoutView_tmpl.html 736b957 dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html b8d28eb dashboardv2/public/js/templates/business_catalog/BusinessCatalogDetailLayoutView_tmpl.html 3f6df14 dashboardv2/public/js/templates/business_catalog/TreeLayoutView_tmpl.html fd50bda dashboardv2/public/js/templates/common/TableLayout_tmpl.html 64c7c19 dashboardv2/public/js/templates/common/buttons_tmpl.html PRE-CREATION dashboardv2/public/js/templates/common/modal.html ef59290 dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 18da242 dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html b01352c dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html 7b79e09 dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 21300b2 dashboardv2/public/js/templates/search/AdvancedSearchInfo_tmpl.html 3e13fce dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 911522e dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html cedd318 dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html 26d283b dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html f32ce1c dashboardv2/public/js/templates/tag/TagAttributeItemView_tmpl.html dfd2b72 dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html c653239 dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html cce584a dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 8b0b63d dashboardv2/public/js/utils/CommonViewFunction.js 48ee41f dashboardv2/public/js/utils/Messages.js eab7d14 dashboardv2/public/js/utils/Overrides.js 615e3b1 dashboardv2/public/js/utils/TableLayout.js e2d28c7 dashboardv2/public/js/utils/Utils.js 6d378bc dashboardv2/public/js/views/audit/AuditTableLayoutView.js 223e728 dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js 71332d7 dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js c7fcfa1 dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js 28a658a dashboardv2/public/js/views/business_catalog/TreeLayoutView.js 998c8f4 dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 5f172e9 dashboardv2/public/js/views/entity/CreateEntityLayoutView.js d461d09 dashboardv2/public/js/views/schema/SchemaLayoutView.js 585cf1b dashboardv2/public/js/views/search/SearchLayoutView.js cd8c291 dashboardv2/public/js/views/search/SearchQueryView.js b07c325 dashboardv2/public/js/views/search/SearchResultLayoutView.js c8c83de dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 01c8d8b dashboardv2/public/js/views/tag/TagDetailLayoutView.js 410c629 dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 1ed6c0d dashboardv2/public/js/views/tag/TagLayoutView.js 658cab3 dashboardv2/public/js/views/tag/addTagModalView.js e240974 Diff: https://reviews.apache.org/r/62355/diff/1/ Testing ------- Done one round of sanity testing. Thanks, keval bhatt