-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62342/
-----------------------------------------------------------

(Updated Sept. 26, 2017, 9:49 a.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2136
    https://issues.apache.org/jira/browse/ATLAS-2136


Repository: atlas


Description
-------

Currently audit and notification entityChangeListeners is using v1 API. This 
needs to be migrated to start using v2 APIs. This is needed for notification of 
tag propagation.
Also provide a new REST API to get audit events for an entity using v2 structure


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf5 
  intg/src/main/java/org/apache/atlas/listener/AtlasEntityChangeListener.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/listener/AtlasRelationshipChangeListener.java
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677a 
  intg/src/main/java/org/apache/atlas/listener/TypeDefChangeListener.java 
e8ac8f4a 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasClassificationNotification.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasEntityNotification.java
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/notification/AtlasNotification.java 
PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationType.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasRelationshipNotification.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/AtlasTypeDefNotification.java
 PRE-CREATION 
  
intg/src/main/java/org/apache/atlas/model/notification/EntityNotificationV2.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasEntityAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasTypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 9dc78350 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 5a5a2c10 
  
repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
 22d2a810 
  
repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
 c3826019 
  
repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
 76acf8ce 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 8aa22377 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 5a0b74e3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 bd82eb51 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
 7b349c46 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 a5db81bf 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipChangeNotifier.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
 9b273193 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 603516d4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
 ad88c1b3 
  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
99d21078 
  repository/src/test/java/org/apache/atlas/TestModules.java 144f6182 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryV2TestBase.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java
 7901ef68 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
 ef8bd2f2 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
 94cc5b93 
  
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
 e93f08d6 
  
webapp/src/main/java/org/apache/atlas/notification/AtlasEntityNotificationListener.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/notification/AtlasRelationshipNotificationListener.java
 PRE-CREATION 
  
webapp/src/main/java/org/apache/atlas/notification/AtlasTypeDefNotificationListener.java
 PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 0f6eeb11 


Diff: https://reviews.apache.org/r/62342/diff/4/

Changes: https://reviews.apache.org/r/62342/diff/3-4/


Testing
-------

Validated HBase audit events and Kafka notification message for the following 
operations:
1. Entity Create
2. Entity Update
3. Entity Delete
4. Add Classification
5. Delete Classification
6. Update Classification

Listeners were notified using v2 API structure


Thanks,

Sarath Subramanian

Reply via email to