----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62585/#review186315 -----------------------------------------------------------
Fix it, then Ship it! client/common/pom.xml Lines 25 (patched) <https://reviews.apache.org/r/62585/#comment262809> 0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT client/src/main/java/org/apache/atlas/AtlasBaseClient.java Line 62 (original), 67 (patched) <https://reviews.apache.org/r/62585/#comment262813> Consider avoiding references to API_V1 and API_V2 in 'common'; instead use the interface API. Consider one of the following approaches to get API object in AtlasBaseClient: 1) Abstract methods: - protected abstract API getVersionAPI(); - protected abstract API getStatusAPI(); - protected abstract API getMetricsAPI(); 2)Have the implementations pass API references vi AtlasBaseClient constructor: - protected AtlasBaseClient(API version, API status, API metrics); client/v1-client/pom.xml Lines 25 (patched) <https://reviews.apache.org/r/62585/#comment262810> 0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT client/v2-client/pom.xml Lines 25 (patched) <https://reviews.apache.org/r/62585/#comment262812> 0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT - Madhan Neethiraj On Sept. 26, 2017, 7:17 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62585/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 7:17 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2179 > https://issues.apache.org/jira/browse/ATLAS-2179 > > > Repository: atlas > > > Description > ------- > > Split client library into V1 and V2 artifacts for lighter JARs > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > fc611c8a > client/common/pom.xml PRE-CREATION > client/pom.xml 9d411760 > client/src/main/assembly/all-jar.xml PRE-CREATION > client/src/main/java/org/apache/atlas/AtlasAdminClient.java > client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2 > client/src/main/java/org/apache/atlas/AtlasClient.java 5fa5df79 > client/src/main/java/org/apache/atlas/AtlasClientV2.java 2cb9e84b > client/src/main/java/org/apache/atlas/AtlasServerEnsemble.java > client/src/main/java/org/apache/atlas/AtlasServiceException.java b128f982 > client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java > client/src/main/java/org/apache/atlas/EntityAuditEvent.java > client/src/main/java/org/apache/atlas/ResourceCreator.java > client/src/main/java/org/apache/atlas/SerDe.java > client/src/main/java/org/apache/atlas/security/SecureClientUtils.java > client/src/test/java/org/apache/atlas/AtlasClientTest.java c33906ac > client/v1-client/pom.xml PRE-CREATION > client/v2-client/pom.xml PRE-CREATION > common/pom.xml 7178bfa6 > common/src/main/java/org/apache/atlas/ApplicationProperties.java > common/src/main/java/org/apache/atlas/AtlasException.java > common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java > a6e1689c > > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java > > common/src/main/java/org/apache/atlas/security/SecurityProperties.java > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java > common/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java > > common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java > > > common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTicketBasedKafkaClientTest.java > > intg/src/test/resources/atlas-jaas.properties PRE-CREATION > intg/src/test/resources/test.properties PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > ad88c1b3 > > > Diff: https://reviews.apache.org/r/62585/diff/1/ > > > Testing > ------- > > compile goes through fine > mvn clean package also goes through fine > > > Thanks, > > Apoorv Naik > >
