----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62463/#review187120 -----------------------------------------------------------
None of the attributes are marked with 'isIndexable=true'. This will make searching on these attributes very inefficient and slow. Please review entity & classification attributes and update indexable flag as necessary. Rest of the changes look good. - Madhan Neethiraj On Oct. 4, 2017, 12:27 p.m., David Radley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62463/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 12:27 p.m.) > > > Review request for atlas, Nigel Jones, Madhan Neethiraj, and Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > ATLAS1836 Add Area 0 models > > > Diffs > ----- > > addons/models/0000-Area0/0015-LinkedMediaTypes_model.json PRE-CREATION > addons/models/0000-Area0/0017-ExternalIdentifiers_model.json PRE-CREATION > addons/models/0000-Area0/0020-PropertyFacets_model.json PRE-CREATION > addons/models/0000-Area0/0025-Locations_model.json PRE-CREATION > addons/models/0000-Area0/0030-HostsAndPlatforms_model.json PRE-CREATION > addons/models/0000-Area0/0035-ComplexHosts_model.json PRE-CREATION > addons/models/0000-Area0/0040-Servers_model.json PRE-CREATION > addons/models/0000-Area0/0070-NetworksAndGateways_model.json PRE-CREATION > addons/models/0000-Area0/0090-CloudPlatformsAndServices.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/62463/diff/2/ > > > Testing > ------- > > Start Atlas and get the types to check they have been added. > > > Thanks, > > David Radley > >
