----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63029/#review188140 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Oct. 16, 2017, 1:29 p.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63029/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 1:29 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sharmadha Sainath. > > > Bugs: ATLAS-2212 > https://issues.apache.org/jira/browse/ATLAS-2212 > > > Repository: atlas > > > Description > ------- > > 1. Created a tag with int attribute. > 2. Tried to associate the tag to an entity with tag attribute value as -1. > Unable to provide negative value.(i.e) minus sign is not accepted. > 3. Able to set negative value for int if value is changed using Up and Down > Arrow . > 4. This behavior is not observed for short,byte,float,double attribute > values. Able to provide negative value directly for datatypes other than int. > > > Diffs > ----- > > dashboardv2/public/js/utils/Overrides.js 4ffda57 > dashboardv2/public/js/views/tag/addTagModalView.js 423a92e > > > Diff: https://reviews.apache.org/r/63029/diff/1/ > > > Testing > ------- > > I have tested with negative value is working as expected. > > > Thanks, > > pratik pandey > >
