> On Oct. 13, 2017, 4:52 p.m., Apoorv Naik wrote:
> > client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java
> > Lines 387 (patched)
> > <https://reviews.apache.org/r/62984/diff/1/?file=1855117#file1855117line387>
> >
> >     formatPathParameters call is not needed here
> >     
> >     instead do exactly what you did for the get call
> >     
> >     ```java 
> >     public static final API_V2 DELETE_RELATIONSHIP_BY_GUID = new 
> > API_V2(RELATIONSHIPS_URI + "guid/", HttpMethod.DELETE, 
> > Response.Status.NO_CONTENT);
> >     
> >     public void deleteRelationshipByGuid(String guid) throws 
> > AtlasServiceException {
> >         callAPI(API_V2.DELETE_RELATIONSHIP_BY_GUID, 
> > AtlasRelationship.class, null, guid);
> >     }
> >     ```

Note that the response is null so I set it to null (instead of 
AtlasRelationship.class) and it seems to return 204 no content ok. Let me know!


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62984/#review188019
-----------------------------------------------------------


On Oct. 13, 2017, 2:48 p.m., Andrew Hulbert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62984/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 2:48 p.m.)
> 
> 
> Review request for atlas and Apoorv Naik.
> 
> 
> Bugs: ATLAS-2210
>     https://issues.apache.org/jira/browse/ATLAS-2210
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add calls to get and delete relationships to AtlasClientV2
> 
> 
> Diffs
> -----
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 24a3ef6 
> 
> 
> Diff: https://reviews.apache.org/r/62984/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Hulbert
> 
>

Reply via email to